Opened 10 years ago

Closed 10 years ago

#10871 closed enhancement (fixed)

Intersections of permutation groups

Reported by: rbeezer Owned by: joyner
Priority: minor Milestone: sage-4.7
Component: group theory Keywords:
Cc: dimpase Merged in: sage-4.7.alpha3
Authors: Rob Beezer, Mike Hansen Reviewers: Dmitrii Pasechnik
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by rbeezer)

This method for permutation groups wraps the GAP Intersection command.

Apply trac_10871-intersection-permutation-groups-v2.patch

Attachments (2)

trac_10871-intersection-permutation-groups.patch (2.6 KB) - added by rbeezer 10 years ago.
trac_10871-intersection-permutation-groups-v2.patch (2.5 KB) - added by rbeezer 10 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 10 years ago by rbeezer

  • Authors set to Rob Beezer
  • Cc dimpase added
  • Status changed from new to needs_review

comment:2 follow-up: Changed 10 years ago by mhansen

I think it'd be better to just use

return PermutationGroup(gap_group=gap.Intersection(self, other))

comment:3 in reply to: ↑ 2 ; follow-up: Changed 10 years ago by rbeezer

  • Status changed from needs_review to needs_work

Replying to mhansen:

Thanks, Mike - yes, that'd be better. I'd forgotten about the more Python-like syntax being available.

comment:4 in reply to: ↑ 3 ; follow-up: Changed 10 years ago by dimpase

Replying to rbeezer:

Replying to mhansen:

Thanks, Mike - yes, that'd be better. I'd forgotten about the more Python-like syntax being available.

Indeed, this looks better (especially given that % stuff is going away in Python 3, AFAIK).

comment:5 in reply to: ↑ 4 ; follow-up: Changed 10 years ago by rbeezer

  • Authors changed from Rob Beezer to Rob Beezer, Mike Hansen
  • Description modified (diff)
  • Status changed from needs_work to needs_review

Replying to dimpase:

Indeed, this looks better (especially given that % stuff is going away in Python 3, AFAIK).

Yes, the string formatting is being replaced, but I think I read that it will have an extra-long grace period. Anyway, hopefully there will be tools to automate the conversions.

v2 patch incorporates Mike's suggestion and uses the new string-formatting routine for the error message.

comment:6 in reply to: ↑ 5 ; follow-up: Changed 10 years ago by dimpase

  • Status changed from needs_review to positive_review

Replying to rbeezer:

Replying to dimpase:

Indeed, this looks better (especially given that % stuff is going away in Python 3, AFAIK).

Yes, the string formatting is being replaced, but I think I read that it will have an extra-long grace period. Anyway, hopefully there will be tools to automate the conversions.

v2 patch incorporates Mike's suggestion and uses the new string-formatting routine for the error message.

OK. Checked, it works. Positive review.

comment:7 in reply to: ↑ 6 Changed 10 years ago by rbeezer

  • Reviewers set to Dmitrii Pasechnik

Replying to dimpase:

Thanks, Dima!

comment:8 Changed 10 years ago by rbeezer

Just checked, this should apply fine to 4.7.alpha1.

comment:9 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.7.alpha3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.