Opened 12 years ago

Closed 8 years ago

#10838 closed enhancement (wontfix)

A library interface for Bernd Souvignier's code

Reported by: rlm Owned by: justin
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: quadratic forms Keywords:
Cc: Merged in:
Authors: Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by rlm)

All within one process, no files written to or read from:

        sage: from sage.quadratic_forms import isoautom
        sage: s = """#1
        ... 3x0
        ... 2
        ... 0 3
        ... 0 0 5
        ... 3x0
        ... 5
        ... 0 3
        ... 0 0 1
        ... """
        sage: x = isoautom.call_main_isom(['isom'], s)
        sage: x
        'The lattices are not isomorphic !\nDifferent numbers of short vectors (5|2)\n'
        sage: s = """#1
        ... 3x0
        ... 1
        ... 0 3
        ... 0 0 5
        ... 3x0
        ... 5
        ... 0 3
        ... 0 0 1
        ... """
        sage: x = isoautom.call_main_isom(['isom'], s)
        sage: x
        '3\n  0  0  1\n  0  1  0\n  1  0  0\n'
        sage: print x
        3
          0  0  1
          0  1  0
          1  0  0

Attachments (2)

isoautom.patch (140.2 KB) - added by rlm 12 years ago.
isoautom.2.patch (140.2 KB) - added by jonhanke 12 years ago.
Minor update to the previous filei, fixing the doctest quotes.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 12 years ago by rlm

This patch is only a first step. We need to create the 'dependencies.h' file, replace the load/dump file function with a structure which lets us interface directly, write the wrappers, etc...

Changed 12 years ago by rlm

Attachment: isoautom.patch added

comment:2 Changed 12 years ago by rlm

New patch lets you give an input string to the isom function, and gives a string as output. Still rudimentary, but a proof of concept. Be careful calling it on invalid input, I haven't really worried about that yet.

comment:3 Changed 12 years ago by rlm

Description: modified (diff)

Changed 12 years ago by jonhanke

Attachment: isoautom.2.patch added

Minor update to the previous filei, fixing the doctest quotes.

comment:4 Changed 8 years ago by jdemeyer

Milestone: sage-duplicate/invalid/wontfix
Reviewers: Jeroen Demeyer
Status: newneeds_review

Invalid since this is an interface to an old package without copyright information and the functionality is provided by PARI anyway (but not yet exposed to Sage).

Last edited 8 years ago by jdemeyer (previous) (diff)

comment:5 Changed 8 years ago by jdemeyer

Status: needs_reviewpositive_review

comment:6 Changed 8 years ago by vbraun

Resolution: wontfix
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.