Opened 8 years ago
Last modified 5 years ago
#10830 needs_work enhancement
Make pari support SAGE_SPKG_INSTALL_DOCS
Reported by: | jason | Owned by: | tbd |
---|---|---|---|
Priority: | major | Milestone: | sage-6.4 |
Component: | packages: standard | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jason Grout | Reviewers: | David Kirkby |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
This ticket implements #10823 for pari. New spkg at http://sage.math.washington.edu/home/jason/spkg-docs/pari-2.4.3.alpha.p6.spkg
Attachments (1)
Change History (11)
comment:1 Changed 8 years ago by
- Status changed from new to needs_review
comment:2 Changed 8 years ago by
- Reviewers set to David Kirkby
- Status changed from needs_review to needs_work
comment:3 Changed 8 years ago by
- Description modified (diff)
- Status changed from needs_work to needs_review
New spkg up.
comment:4 Changed 8 years ago by
- Status changed from needs_review to needs_work
The '-r' is unnecessary on the 'cp' command.
I think I know what you are trying to achieve, but be warned this syntax would never work if there were pdf files in sub-directories. Luckily in this case there are not, so a simple 'cp', with no options, will do.
If there were however any PDFs in sub-directories, and it was not possible to do a simple cp -r, because of other files, then one would probably use 'find' to locate the PDF files and tar to copy them from one place and put them in another. The syntax for doing this is non-trivial, and would be something like that below, where one:
- Uses 'find' to find all the PDF files.
- Uses 'tar' to create an archive of the PDF files, but instead of writing it to an intermediate file, one writes the archive on standard output.
- Uses 'cd' to change to the directory where the files need to be extracted.
- Uses 'tar', which reads from standard input, to extract the files written by the other tar.
tar cf - `find doc -name '*.pdf'` | ( cd "$SAGE_ROOT/local/share/doc/pari"; tar xfp -)
Note the above is untested.
In this case, simply remove the '-r' and what you have will be get a positive review.
Dave
comment:5 Changed 8 years ago by
Good catch! The -r was mistakenly copied. There are no subdirectories in this case.
comment:6 Changed 8 years ago by
See #11197 for building docs after sage is built.
comment:7 Changed 6 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:8 Changed 5 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:9 Changed 5 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:10 Changed 5 years ago by
- Milestone changed from sage-6.3 to sage-6.4
See comments on #10828