Opened 9 years ago

Last modified 5 years ago

#10827 needs_work enhancement

Make cython support SAGE_SPKG_INSTALL_DOCS

Reported by: jason Owned by: tbd
Priority: major Milestone: sage-6.4
Component: packages: standard Keywords: sd32
Cc: Merged in:
Authors: Jason Grout, John Palmieri Reviewers: David Kirkby
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Attachments (2)

10827.patch (1.3 KB) - added by jason 9 years ago.
FYI Only---already applied to spkg.
trac_10827-cython-spkg.patch (1.6 KB) - added by jhpalmieri 8 years ago.
for reference only; do not apply

Download all attachments as: .zip

Change History (23)

comment:1 Changed 9 years ago by jason

  • Status changed from new to needs_review

comment:2 Changed 9 years ago by drkirkby

  • Reviewers set to David Kirkby
  • Status changed from needs_review to needs_work

See comments on #10828

comment:3 Changed 9 years ago by jason

Yes, this was done before #10828 was finalized. I'll post a new spkg.

Changed 9 years ago by jason

FYI Only---already applied to spkg.

comment:4 Changed 9 years ago by jason

  • Description modified (diff)
  • Status changed from needs_work to needs_review

New spkg up; see the new URL in the description.

comment:5 Changed 9 years ago by jason

  • Description modified (diff)

comment:6 Changed 9 years ago by drkirkby

  • Status changed from needs_review to needs_info

See my comments on #10828 I'm not saying this needs work, as it might not do, but if its anything like the matplotlib case, a lot of unnecessary files get copied.

We should clarify this before marking this for review.

Dave

comment:7 Changed 9 years ago by jason

  • Status changed from needs_info to needs_review

The cython docs that are copied contain just the standalone built files, not the full doc source directory.

comment:8 Changed 9 years ago by drkirkby

  • Status changed from needs_review to positive_review

That's ok then

comment:9 Changed 9 years ago by jdemeyer

  • Merged in set to sage-4.7.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:10 Changed 8 years ago by jdemeyer

  • Merged in sage-4.7.alpha1 deleted
  • Resolution fixed deleted
  • Status changed from closed to new

Cython doesn't build from scratch using SAGE_SPKG_INSTALL_DOCS, see also #10826.

comment:11 Changed 8 years ago by jdemeyer

  • Status changed from new to needs_work

comment:12 Changed 8 years ago by jason

See #11197 for building docs after sage is built.

comment:13 Changed 8 years ago by jason

See the bottom of #11197 for some other things that need to be done: add doc/ to .hgignore, and delete SPKG.txt.orig.

comment:14 Changed 8 years ago by jhpalmieri

  • Authors changed from Jason Grout to Jason Grout, John Palmieri
  • Description modified (diff)
  • Status changed from needs_work to needs_review

Here's a new spkg, based strongly on Jason's old one. I'm attaching the patch for reference.

Changed 8 years ago by jhpalmieri

for reference only; do not apply

comment:15 Changed 8 years ago by was

  • Keywords sd32 added

comment:16 Changed 8 years ago by kcrisman

  • Status changed from needs_review to needs_work

In the meantime Cython is version 0.15.1.

comment:17 Changed 8 years ago by kcrisman

I think we're also using different syntax for checking if SAGE_LOCAL is defined now.

comment:18 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:19 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:20 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:21 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4
Note: See TracTickets for help on using tickets.