Opened 9 years ago

Closed 8 years ago

#10808 closed defect (worksforme)

atlas-3.8.3.p16 doesn't build on ARM

Reported by: Snark Owned by: drkirkby
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: porting Keywords:
Cc: Merged in:
Authors: Reviewers: Julien Puydt, Dmitrii Pasechnik
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

This makes sage-4.6.1 not build on ARM ; here is a patch that makes it build.

Attachments (1)

atlas-no-m32-on-ARM.diff (1.1 KB) - added by Snark 8 years ago.
This patch to the atlas in 4.7.1 makes it possible to compile on ARM

Download all attachments as: .zip

Change History (14)

comment:1 Changed 9 years ago by Snark

  • Status changed from new to needs_review

This makes sage-4.6.2 also not build on ARM ; the same patch works.

comment:2 Changed 8 years ago by dimpase

  • Status changed from needs_review to positive_review

it looks quite harmless for non-ARM machines, so this can be included, IMHO. I can't test this on an ARM, though.

comment:3 follow-up: Changed 8 years ago by fbissey

  • Status changed from positive_review to needs_work

This patch looks geared towards atlas-3.9.32 does it apply to the current version in sage? And there should be a spkg.

comment:4 in reply to: ↑ 3 Changed 8 years ago by dimpase

Replying to fbissey:

This patch looks geared towards atlas-3.9.32 does it apply to the current version in sage? And there should be a spkg.

Oops, my bad:–(

I haven't noticed the wrong Atlas version.

comment:5 Changed 8 years ago by Snark

The newly-released 4.7.1 still ships with an atlas which doesn't compile on ARM, so I came to check where that report stands ; is it sure that a fixed spkg will find its way into sage-4.7.2 ?

comment:6 Changed 8 years ago by fbissey

There are numerous problems with the atlas 3.9.xx series (it causes some strange behaviors in iml and linbox at least). As it stands we won't be using it for 4.7.2.

If you want to provide a patch against atlas-3.8.4, we could try to include that in 4.7.2 relatively quickly.

comment:7 Changed 8 years ago by Snark

I'm still compiling sage 4.7.1 and it will probably wait until monday before I'm able to provide a cleaner patch than the one I currently use, but I'll work on one.

Changed 8 years ago by Snark

This patch to the atlas in 4.7.1 makes it possible to compile on ARM

comment:8 Changed 8 years ago by Snark

The patch described above is visibly clean, since it only modifies the code on ARM platforms

comment:9 Changed 8 years ago by fbissey

Thanks for the patch. I'll try to make a new spkg based on it so it can be included in 4.7.2.

comment:10 Changed 8 years ago by Snark

The singular in 4.8, 3.8.4.p1, compiles correctly on ARM : please close that report as obsolete, invalid or some such.

comment:11 Changed 8 years ago by dimpase

  • Status changed from needs_work to positive_review

comment:12 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.0 to sage-duplicate/invalid/wontfix

comment:13 Changed 8 years ago by jdemeyer

  • Resolution set to worksforme
  • Reviewers set to Julien Puydt, Dmitrii Pasechnik
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.