Opened 9 years ago

Closed 9 years ago

#10796 closed defect (fixed)

Platonic solid constructors scale and translate in the wrong order.

Reported by: robertwb Owned by: jason, was
Priority: major Milestone: sage-4.7
Component: graphics Keywords:
Cc: kcrisman, mvngu Merged in: sage-4.7.alpha5
Authors: Robert Bradshaw, Karl-Dieter Crisman Reviewers: Karl-Dieter Crisman, Robert Bradshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by kcrisman)

This means that if there is a scale and center argument, the true center is "scaled" away fron the origin.

Apply only attachment:trac_10796-platonic-and-doc.patch

Attachments (2)

10796-platonic.patch (730 bytes) - added by robertwb 9 years ago.
trac_10796-platonic-and-doc.patch (2.4 KB) - added by kcrisman 9 years ago.
Apply only this patch

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by robertwb

comment:1 Changed 9 years ago by robertwb

  • Status changed from new to needs_review

comment:2 Changed 9 years ago by kcrisman

  • Cc kcrisman added

Changed 9 years ago by kcrisman

Apply only this patch

comment:3 Changed 9 years ago by kcrisman

  • Authors set to Robert Bradshaw, Karl-Dieter Crisman
  • Description modified (diff)
  • Reviewers set to Karl-Dieter Crisman

This patch takes Robert's patch and adds documentation to show it works, as well as adding a little so this module is at 100%. Only the documentation needs review, hopefully should be fine. Looks good in the ref manual, should check this out.

Followup ticket: There are some multiline plots in this file that do not work in the live documentation because of using slashes to continue lines, which apparently Sphinx doesn't pick up. See #10922.

comment:4 Changed 9 years ago by kcrisman

  • Cc mvngu added

comment:5 Changed 9 years ago by robertwb

The docs look fine to me.

comment:6 Changed 9 years ago by kcrisman

  • Reviewers changed from Karl-Dieter Crisman to Karl-Dieter Crisman, Robert Bradshaw
  • Status changed from needs_review to positive_review

Great. Nice catch, by the way.

comment:7 Changed 9 years ago by jdemeyer

  • Merged in set to sage-4.7.alpha5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.