Opened 11 years ago

Closed 11 years ago

#10790 closed enhancement (fixed)

add Dyck graph to the common graphs database

Reported by: kini Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-4.7
Component: graph theory Keywords:
Cc: Merged in: sage-4.7.alpha3
Authors: Keshav Kini Reviewers: Nathann Cohen, Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by kini)

Part of the larger project at #9136 .

Depends on #10781

Apply trac_10790-Dyck-graph.patch

Attachments (2)

trac_10790-reviewer.patch​ (2.7 KB) - added by ncohen 11 years ago.
trac_10790-Dyck-graph.patch​ (5.1 KB) - added by kini 11 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 11 years ago by kini

  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 11 years ago by kini

  • Description modified (diff)

Depends on #10781 string for the patchbot to read

comment:3 Changed 11 years ago by ncohen

Nothing to complain about here, except long lines like on #10781. Same remark :-)

(very pretty layout, by the way !)

Nathann

Changed 11 years ago by ncohen

comment:4 Changed 11 years ago by kini

Same remark as on #10781. Glad you liked the layout! I was, rather, afraid it would be seen more as pretentious or silly, haha.

comment:5 Changed 11 years ago by kini

  • Description modified (diff)
  • Status changed from needs_review to positive_review

Same comment, again, as on #10781.

comment:6 Changed 11 years ago by kini

  • Reviewers set to Nathann Cohen

comment:7 Changed 11 years ago by jdemeyer

  • Milestone set to sage-4.7

comment:8 Changed 11 years ago by jdemeyer

  • Status changed from positive_review to needs_work

Since the hyperlink to the MathWorld and Wikipedia articles are not meant to be refered to from a different place, you should make links with two trailing underscores. See ​http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#embedded-uris

Changed 11 years ago by kini

comment:9 Changed 11 years ago by kini

  • Status changed from needs_work to needs_review

Same comment as on #10781. Well, except with MathWorld? replaced with MathWorld, I guess :)

comment:10 Changed 11 years ago by jdemeyer

  • Reviewers changed from Nathann Cohen to Nathann Cohen, Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:11 Changed 11 years ago by jdemeyer

  • Merged in set to sage-4.7.alpha3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.