Opened 11 years ago

Closed 11 years ago

#10780 closed defect (fixed)

fix exception-eating bug in sagenb/misc/misc.py

Reported by: kini Owned by: jason, mpatel, was
Priority: major Milestone: sage-4.7
Component: notebook Keywords: notebook, exception handling
Cc: roed@… Merged in: sage-4.7.alpha1
Authors: David Roe Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by kini)

See this sage-devel post.

Apply to sagenb

Attachments (1)

trac_10780-regurgitate-exception.patch (611 bytes) - added by kini 11 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 11 years ago by kini

  • Authors set to David Roe
  • Cc roed@… added
  • Status changed from new to needs_review

Here is a patch adding the three lines of code David Roe gave in his sage-devel post. I've attributed the patch to him - hopefully that was the right thing to do?

comment:2 Changed 11 years ago by roed

It's fine with me, but someone else should probably review it.

comment:3 Changed 11 years ago by kini

  • Description modified (diff)

Apply to sagenb

(hopefully patchbot can read the above someday)

comment:4 Changed 11 years ago by vbraun

  • Status changed from needs_review to positive_review

Looks good to me.

comment:5 Changed 11 years ago by jdemeyer

  • Reviewers set to Volker Braun
  • Status changed from positive_review to needs_work

Edit the commit message of the patch (use hg qrefresh -e for that) such that the ticket number appears on the first line.

Changed 11 years ago by kini

comment:6 Changed 11 years ago by kini

  • Status changed from needs_work to needs_review

Sorry about that. I'll be more careful in the future.

comment:7 Changed 11 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:8 Changed 11 years ago by jdemeyer

  • Merged in set to sage-4.7.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.