Opened 8 years ago

Closed 8 years ago

#10756 closed defect (fixed)

Cliquer does not like empty graphs

Reported by: ncohen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-4.7
Component: graph theory Keywords: cliquer
Cc: Merged in: sage-4.7.alpha2
Authors: Nathann Cohen Reviewers: Mike Hansen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Before :

sage: Graph(1).clique_maximum()
[0]
sage: Graph().clique_maximum()
cliquer file graph.c: line 31: assertion failed: (n>0)
/home/ncohen/sage/local/bin/sage-sage: line 300: 17630 Aborted                 (core dumped) sage-ipython "$@" -i
~$ 

After

sage: Graph(1).clique_maximum()
[0]
sage: Graph().clique_maximum()
[]

Attachments (1)

trac_10756.patch (791 bytes) - added by ncohen 8 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by ncohen

  • Status changed from new to needs_review

comment:2 Changed 8 years ago by mhansen

  • Reviewers set to Mike Hansen
  • Status changed from needs_review to positive_review

Looks good to me.

comment:3 Changed 8 years ago by jdemeyer

  • Status changed from positive_review to needs_work

What's the point of the test in the ticket?

I suppose you want to add a test like

sage: Graph(1).clique_maximum()
[0]
sage: Graph().clique_maximum()
[]

comment:4 Changed 8 years ago by ncohen

  • Status changed from needs_work to positive_review

Gloops.... Sorry 'bout that O_o

Nathann

comment:5 Changed 8 years ago by jdemeyer

  • Status changed from positive_review to needs_work

The

sage: Graph().clique_maximum()
[]

test (which is precisely what this ticket fixes) is still missing.

comment:6 Changed 8 years ago by ncohen

  • Status changed from needs_work to needs_review

Argggggggggggg !!!

Right... Updated :-p

Nathann

Changed 8 years ago by ncohen

comment:7 Changed 8 years ago by robertwb

  • Status changed from needs_review to positive_review

comment:8 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-4.6.2 to sage-4.7

comment:9 Changed 8 years ago by jdemeyer

  • Merged in set to sage-4.7.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.