Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#10749 closed defect (duplicate)

libpng-1.2.35.p2 has syntax errors in its spkg-install

Reported by: mhansen Owned by: tbd
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Reviewers: Mariah Lenox
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mhansen)

The fix is the following change: 

diff --git a/spkg-install b/spkg-install
--- a/spkg-install
+++ b/spkg-install
@@ -43,7 +43,7 @@
     exit 1
 fi
 
-if [ $UNAME = "CYGWIN" ]
+if [ $UNAME = "CYGWIN" ]; then
   rm -rf "$SAGE_LOCAL"/lib/libpng12.dll.a
   rm -rf "$SAGE_LOCAL"/lib/libpng12.la
   cp "$SAGE_LOCAL"/bin/cygpng12-0.dll "$SAGE_LOCAL"/lib/libpng12.dll

An spkg can be found at ​http://sage.math.washington.edu/home/mhansen/libpng-1.2.35.p3.spkg

Change History (5)

comment:1 Changed 10 years ago by mhansen

  • Description modified (diff)
  • Milestone set to sage-4.6.2
  • Status changed from new to needs_review

comment:2 Changed 10 years ago by mariah

  • Milestone changed from sage-4.7 to sage-duplicate/invalid/wontfix

This was fixed by #11110.

comment:3 Changed 10 years ago by jhpalmieri

  • Status changed from needs_review to positive_review

(This can be closed, as the previous comment says.)

comment:4 Changed 10 years ago by jdemeyer

  • Authors Mike Hansen deleted
  • Resolution set to duplicate
  • Reviewers set to Mariah Lenox
  • Status changed from positive_review to closed

comment:5 Changed 10 years ago by kcrisman

For the record, this was actually fixed in #9146 by a friendly referee patch.

Note: See TracTickets for help on using tickets.