Opened 11 years ago

Closed 11 years ago

#10702 closed enhancement (fixed)

Add patchbot to the developers guide

Reported by: mstreng Owned by: mvngu
Priority: minor Milestone: sage-4.6.2
Component: documentation Keywords: patchbot, buildbot, bot, trac, documentation, developers guide
Cc: jdemeyer Merged in: sage-4.6.2.alpha4
Authors: Marco Streng Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Add a link to the patchbot wiki in the developers guide (see this thread).

Attachments (1)

trac_10702-patchbot-doc.patch (988 bytes) - added by mstreng 11 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by mstreng

  • Authors set to Marco Streng
  • Keywords patchbot buildbot bot trac documentation developers guide added
  • Milestone set to sage-4.6.2
  • Status changed from new to needs_review

comment:2 Changed 11 years ago by aapitzsch

  • Reviewers set to André Apitzsch
  • Status changed from needs_review to positive_review

It looks good to me.

comment:3 Changed 11 years ago by jdemeyer

  • Status changed from positive_review to needs_work

Marco: please fix the commit message of your patch (use hg qrefresh -e for that).

Changed 11 years ago by mstreng

comment:4 follow-up: Changed 11 years ago by mstreng

  • Cc jdemeyer added
  • Status changed from needs_work to needs_review

What do you mean by "fix"? Is it ok now? That was a lot of work for just removing "[mq]: " (of which I don't know where it came from or what it means).

comment:5 in reply to: ↑ 4 ; follow-up: Changed 11 years ago by jdemeyer

  • Status changed from needs_review to positive_review

Replying to mstreng:

What do you mean by "fix"? Is it ok now? That was a lot of work for just removing "[mq]: " (of which I don't know where it came from or what it means).

Yes, it looks okay now. The [mq] stands for "Mercurial queue". By default the commit message comes from the argument to hg qnew. But in Sage, we like to have "proper" informative commit messages (also, including the ticket number on the first line).

Why was it a lot of work, what did you do?

comment:6 in reply to: ↑ 5 Changed 11 years ago by mstreng

Replying to jdemeyer:

Why was it a lot of work, what did you do?

log in to a machine that has Sage, copy patch location, hg qimport, hg qapply, hg qrefresh -e, remove "[mq]: " from the commit message, hg export, copy patch to office pc, log in to trac, upload patch, tick needs_review, click Submit

All that to remove four characters from a commit message.

Why couldn't I just edit the patch to remove those 4 characters? Would it have screwed up some kind of checksum?

comment:7 Changed 11 years ago by jdemeyer

  • Merged in set to sage-4.6.2.alpha4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.