Opened 9 years ago

Closed 8 years ago

#10688 closed enhancement (fixed)

Remove weave from Sage

Reported by: jdemeyer Owned by: jdemeyer
Priority: major Milestone: sage-4.7
Component: packages: standard Keywords:
Cc: vbraun Merged in: sage-4.7.alpha1
Authors: Jeroen Demeyer Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

See also #9791

Attachments (1)

10688_remove_weave.patch (1.3 KB) - added by jdemeyer 9 years ago.
SAGE_ROOT patch

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by jdemeyer

SAGE_ROOT patch

comment:1 Changed 9 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Status changed from new to needs_review

comment:2 Changed 9 years ago by jdemeyer

  • Owner changed from tbd to jdemeyer
  • Summary changed from Remove weave? to Remove weave from Sage

comment:3 Changed 9 years ago by fbissey

  • Status changed from needs_review to positive_review

The patch looks to me. You removed all instances of WEAVE that i could find. weave has never been in sage-on-gentoo and it doesn't arm the doctest. I am giving that one a positive review. I'll let #9791 to someone else more familiar with the documentation.

comment:4 Changed 9 years ago by jdemeyer

  • Cc vbraun added

Incidently, this ticket will also be a test-case for #9433.

comment:5 Changed 9 years ago by vbraun

I've never used weave, so I don't have anything new to add to the discussion. I support Jeroen's decision to remove the superfluous spkg, and the patch is how it should be done once the sage_root repository is in place.

comment:6 Changed 9 years ago by maldun

As mentioned in sage devel weave is included in scipy, so it's no loss anyway.

comment:7 Changed 9 years ago by jdemeyer

  • Reviewers set to François Bissey

comment:8 Changed 8 years ago by jdemeyer

  • Merged in set to sage-4.7.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.