Opened 10 years ago

Closed 10 years ago

#10685 closed enhancement (fixed)

All subgroups of a permutation group

Reported by: rbeezer Owned by: joyner
Priority: major Milestone: sage-4.6.2
Component: group theory Keywords:
Cc: wdj, dimpase Merged in: sage-4.6.2.alpha4
Authors: Rob Beezer Reviewers: Dmitrii Pasechnik
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by rbeezer)

New method for permutation groups gets all the subgroups from GAP, via the conjugacy classes of subgroups.

Yes, this takes a very long time to compute and generates tons of output. A big warning in the docstring emphasizes this. But for small groups it is extremely instructive, well worth having, and way better than computing by hand. I've been wanting this for about two years now.

Apply trac_10685-permutation-group-subgroups-v3.patch

Attachments (3)

trac_10685-permutation-group-subgroups.patch (3.0 KB) - added by rbeezer 10 years ago.
trac_10685-permutation-group-subgroups-v2.patch (3.0 KB) - added by rbeezer 10 years ago.
trac_10685-permutation-group-subgroups-v3.patch (3.0 KB) - added by rbeezer 10 years ago.
Rebased, apply only this one

Download all attachments as: .zip

Change History (14)

comment:1 Changed 10 years ago by rbeezer

  • Authors set to Rob Beezer
  • Cc wdj dimpase added
  • Status changed from new to needs_review

comment:2 follow-up: Changed 10 years ago by dimpase

  • Status changed from needs_review to positive_review

that's easy to review :)

comment:3 in reply to: ↑ 2 Changed 10 years ago by rbeezer

Replying to dimpase:

that's easy to review :)

Thanks, Dima. That's gotta be a record for elapsed time. ;-)

comment:4 follow-up: Changed 10 years ago by rbeezer

  • Status changed from positive_review to needs_info

Hi Dima,

A second thought. I'm working with some other code for abelian groups, and there the relevant method is named just .subgroups(). I like that a bit better (and easier to find on tab-completion).

What do you think of calling this by the shorter, plural version?

Rob

comment:5 in reply to: ↑ 4 ; follow-up: Changed 10 years ago by dimpase

Replying to rbeezer:

Hi Dima,

A second thought. I'm working with some other code for abelian groups, and there the relevant method is named just .subgroups(). I like that a bit better (and easier to find on tab-completion).

What do you think of calling this by the shorter, plural version?

sounds actually better; one can also think of eventually having .subgroups(order=666,abelian=true), etc, etc...

Rob

comment:6 in reply to: ↑ 5 ; follow-up: Changed 10 years ago by rbeezer

  • Status changed from needs_info to needs_review

Replying to dimpase:

one can also think of eventually having .subgroups(order=666,abelian=true), etc, etc...

Dima,

Yes, some filters like that would be a good idea (that I had not thought of).

v2 patch simple renames the function and makes the necessary changes in the doctest. Thanks for the extra work on this one.

Rob

comment:7 in reply to: ↑ 6 Changed 10 years ago by dimpase

  • Status changed from needs_review to positive_review

Replying to rbeezer:

Replying to dimpase:

one can also think of eventually having .subgroups(order=666,abelian=true), etc, etc...

Dima,

Yes, some filters like that would be a good idea (that I had not thought of).

v2 patch simple renames the function and makes the necessary changes in the doctest. Thanks for the extra work on this one.

OK, checked. It works.

Rob

comment:8 Changed 10 years ago by jdemeyer

  • Reviewers set to Dmitrii Pasechnik

comment:9 Changed 10 years ago by jdemeyer

  • Status changed from positive_review to needs_work
  • Work issues set to rebase

This needs to be rebased to sage-4.6.2.alpha2

Changed 10 years ago by rbeezer

Rebased, apply only this one

comment:10 Changed 10 years ago by rbeezer

  • Description modified (diff)
  • Status changed from needs_work to positive_review
  • Work issues rebase deleted

Rebased patch on 4.6.2.alpha2 is the "v3" patch.

comment:11 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.6.2.alpha4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.