Opened 10 years ago

Closed 9 years ago

#10658 closed enhancement (fixed)

Compute local components of modular forms

Reported by: davidloeffler Owned by: craigcitro
Priority: major Milestone: sage-5.0
Component: modular forms Keywords: sd35
Cc: GeorgSWeber Merged in: sage-5.0.beta1
Authors: David Loeffler Reviewers: Martin Raum
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by davidloeffler)

This ticket is to introduce a new feature for computing with modular forms in Sage: the explicit computation of the local component of the automorphic representation attached to a newform.

This is based on the algorithms developed by Jared Weinstein and myself. Magma also has this, but this code is an independent implementation and covers some cases the Magma code doesn't (e.g. the Magma code can't distinguish between a newform and its quadratic twist in certain cases).

Apply:

  1. trac_10658-folded.patch

Attachments (5)

trac_10658-local_components.patch (125.9 KB) - added by davidloeffler 10 years ago.
trac_10658-local_components_review.patch (57.5 KB) - added by mraum 10 years ago.
trac_10658-edits.patch (21.0 KB) - added by davidloeffler 10 years ago.
Apply over previous patches
trac_10658-local_components_review.2.patch (57.6 KB) - added by mraum 10 years ago.
trac_10658-folded.patch (130.4 KB) - added by davidloeffler 10 years ago.
Apply only this patch

Download all attachments as: .zip

Change History (16)

Changed 10 years ago by davidloeffler

comment:1 Changed 10 years ago by davidloeffler

  • Status changed from new to needs_review

Depends on #8716, #10443, #10451

comment:2 Changed 10 years ago by davidloeffler

Here's a "first cut". Lots of cases aren't implemented and it needs a bit more general polishing, but it works!

comment:3 Changed 10 years ago by davidloeffler

Depends on #10443, #10451

(Patchbot's confused: it's trying to apply #8716 twice, because it's in the dependencies of this patch and of #10451.)

comment:4 Changed 10 years ago by GeorgSWeber

  • Cc GeorgSWeber added

Changed 10 years ago by mraum

comment:5 Changed 10 years ago by mraum

  • Reviewers set to Martin Raum
  • Status changed from needs_review to needs_work

The review patch contains some doctest that I made fail on purpose; They are (minor) TODOs that, if completed, I would say are sufficient for giving the patch a positive review.

I needed to move the definition of smooth characters (elements) to the top of the file, but the code itself is mainly untouched.

Changed 10 years ago by davidloeffler

Apply over previous patches

comment:6 Changed 10 years ago by davidloeffler

  • Status changed from needs_work to needs_review

Hi Martin,

I've made the changes you suggested. I've also fixed one or two other silly errors (e.g. the code stub for ramified supercuspidals always assumed p was 3 in its return strings) and added TestSuite doctests. Thanks again for reviewing this!

comment:7 Changed 10 years ago by mraum

  • Description modified (diff)
  • Status changed from needs_review to positive_review

The new version of the review patch only differs by the commit message, which was missing before.

comment:8 Changed 10 years ago by jdemeyer

  • Milestone changed from sage-feature to sage-5.0

Changed 10 years ago by davidloeffler

Apply only this patch

comment:9 Changed 10 years ago by davidloeffler

  • Description modified (diff)

Rather than immortalizing the details of the review process in Sage's revision history, here's a single qfolded patch combining the three above.

comment:10 Changed 9 years ago by davidloeffler

  • Keywords sd35 added

comment:11 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.0.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.