Opened 11 years ago
Closed 11 years ago
#10654 closed defect (fixed)
Replace ".. rubric:" with ".. rubric::" in a few files
Reported by: | hivert | Owned by: | mvngu |
---|---|---|---|
Priority: | trivial | Milestone: | sage-4.6.2 |
Component: | documentation | Keywords: | documentation, beginner, days28 |
Cc: | kcrisman | Merged in: | sage-4.6.2.rc0 |
Authors: | Geoffrey Ehrman | Reviewers: | François Bissey |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
The following file contains a miss-written sphinx tag::
popcorn-*ge-combinat/sage $ grep -n "\.\..*rubric: " **/*.py misc/classcall_metaclass.py:215: ..rubric: Discussion structure/unique_representation.py:419: .. rubric: Mixing super types and super classes
Apply:
Attachments (1)
Change History (9)
Changed 11 years ago by
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
comment:2 Changed 11 years ago by
- Cc kcrisman added
comment:3 Changed 11 years ago by
comment:4 Changed 11 years ago by
I just was adding myself on a bunch of tickets I might have time to look at over spring break. If you are ready now, you should review it - I won't have time immediately. Of course, make sure it applies and that the new built doc looks okay (./sage -b; ./sage -docbuild reference html
) if this file is in the reference.
comment:5 Changed 11 years ago by
This one looks fairly trivial. So we should get rid of it quickly, Not sure Jeroen will want it for 4.6.2 though.
I noticed that you added yourself to a bunch of ticket so I decided to have a look at some of them.
comment:6 Changed 11 years ago by
- Description modified (diff)
- Status changed from needs_review to positive_review
Ok tried it. Seen the results in the html, positive review from me.
comment:7 Changed 11 years ago by
- Reviewers set to François Bissey
comment:8 Changed 11 years ago by
- Merged in set to sage-4.6.2.rc0
- Resolution set to fixed
- Status changed from positive_review to closed
The patch looks ok to me. The description is all right and everything. Are you planning to review it Karl?