Changes between Initial Version and Version 14 of Ticket #10651


Ignore:
Timestamp:
03/21/11 16:27:05 (10 years ago)
Author:
nborie
Comment:

In order to fix more things in the same time, I update the description of this ticket. I folded the NT'reviewer from the sage-combinat queue, then I uploaded the patch with a better commit message.

I am very OK with the changes in the Parent structure from Nicolas Thiéry. I give a positive review on all changes touching the corresponding file. The first part of the patch still comes from me, so no review from me.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10651

    • Property Status changed from new to needs_review
    • Property Authors changed from to Nicolas Borie, Nicolas M. Thiéry
    • Property Cc nthiery added
    • Property Summary changed from Small fix in `_an_element_from_iterator` in EnumeratedSets to Make a good use of the EmptySetError in EnumeratedSets and Parent
    • Property Milestone changed from sage-4.6.2 to sage-4.7
    • Property Keywords days28 added
    • Property Reviewers changed from to Paul Zimmermann, Robert Bradshaw, Nicolas Borie
  • Ticket #10651 – Description

    initial v14  
    66StopIteration                             Traceback (most recent call last)
    77
    8 /opt/sage/devel/sage-combinat/<ipython console> in <module>()
     8...
    99
    10 /opt/sage/local/lib/python2.6/site-packages/sage/misc/cachefunc.pyc in __call__(self, *args, **kwds)
    11     329             2
    12     330          """
    13 --> 331         return self._cachedmethod._instance_call(self._instance, *args, **kwds)
    14     332
    15     333     def get_cache(self, *args, **kwds):
    16 
    17 /opt/sage/local/lib/python2.6/site-packages/sage/misc/cachefunc.pyc in _instance_call(self, inst, *args, **kwds)
    18     473             return cache[key]
    19     474         else:
    20 --> 475             cache[key] = self._cachedfunc.f(inst, *args, **kwds)
    21     476             return cache[key]
    22     477
    23 
    24 /opt/sage/local/lib/python2.6/site-packages/sage/categories/enumerated_sets.pyc in _an_element_from_iterator(self)
    25     470             """
    26     471             it = self.__iter__()
    27 --> 472             return it.next()
    28     473
    29     474         # Should this be implemented from first instead?
    3010
    3111StopIteration:
    3212sage:
    3313}}}
     14
     15Also, make the EmptySetError being documented already in the structure of Parent. Improve the documentation of an_element and _an_element_ in Parent.