16 | | Note that not only my review patches need review, but also the original sagenb patches as well. I'm sure there are more elegant ways to do it, but the original scripts patch is fine. I suppose someone could also review the spkg, though there is really almost nothing to review other than bringing it up to developer guide guidelines. See [https://groups.google.com/forum/?fromgroups#!topic/sage-devel/XckI9KRYLOc this sage-devel thread] for a vote about whether this is allowed to be an optional spkg. |
| 16 | Note that not only my review patches need review, but also the original sagenb patches as well. The sagenb stuff is up-to-date in the pull request [https://github.com/sagemath/sagenb/pull/75 75] of sagenb. |
| 17 | |
| 18 | I'm sure there are more elegant ways to do it, but the original scripts patch is fine. |
| 19 | |
| 20 | I suppose someone should also review the spkg, though there is really almost nothing to review other than bringing it up to developer guide guidelines. See [https://groups.google.com/forum/?fromgroups#!topic/sage-devel/XckI9KRYLOc this sage-devel thread] for a vote about whether this is allowed to be an optional spkg. |