Changes between Initial Version and Version 1 of Ticket #10637, comment 52


Ignore:
Timestamp:
06/22/12 01:46:17 (9 years ago)
Author:
kcrisman
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10637, comment 52

    initial v1  
    1414Okay, this should take care of all the work issues.  I've made enough changes in the `sage-sws2rst` file that it definitely needs review, whether from pang or slabbe or someone else.  Please try especially to break it with weird input; but everything else should really be okay, given that my changes to Pablo's great core work is very minimal.
    1515
    16 Note that not only my review patches need review, but also the original sagenb patches as well.  I'm sure there are more elegant ways to do it, but the original scripts patch is fine.  I suppose someone could also review the spkg, though there is really almost nothing to review other than bringing it up to developer guide guidelines.  See [https://groups.google.com/forum/?fromgroups#!topic/sage-devel/XckI9KRYLOc this sage-devel thread] for a vote about whether this is allowed to be an optional spkg.
     16Note that not only my review patches need review, but also the original sagenb patches as well.  The sagenb stuff is up-to-date in the pull request [https://github.com/sagemath/sagenb/pull/75 75] of sagenb.
     17
     18I'm sure there are more elegant ways to do it, but the original scripts patch is fine. 
     19
     20I suppose someone should also review the spkg, though there is really almost nothing to review other than bringing it up to developer guide guidelines.  See [https://groups.google.com/forum/?fromgroups#!topic/sage-devel/XckI9KRYLOc this sage-devel thread] for a vote about whether this is allowed to be an optional spkg.