Changes between Version 10 and Version 12 of Ticket #10635


Ignore:
Timestamp:
09/25/11 21:29:15 (10 years ago)
Author:
leif
Comment:

I've attached a reviewer patch fixing a doctest error in a factorization.

(The order of the factors changes, depending on the sign of a "zero" term in the polynomial which is one factor. The example now looks a bit ugly, but I don't want to wait until we have zero_at() methods for all kinds of domains, and just tagging the whole doctest "# random" would also be odd, IMHO. Note that it previously didn't fail on all 32-bit systems, e.g. not 32-bit SPARC, and tagging the results "# 32-bit" and "# 64-bit" would have been inadequate anyway, since the machine word width is completely unrelated, i.e., that the test failed on x86 processors only is just a weird coincidence.)

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10635

    • Property Status changed from positive_review to closed
    • Property Resolution changed from to fixed
    • Property Merged in changed from to sage-4.7.2.alpha3
  • Ticket #10635 – Description

    v10 v12  
    1414----
    1515
    16 Apply only [attachment:trac_10635-new_version_with_tests.patch] to the Sage library.
     16Apply
     17 1. [attachment:trac_10635-new_version_with_tests.patch]
     18 1. [attachment:trac_10635-fix_doctest_error_due_to_noise.reviewer.patch]
     19to the Sage library.