Opened 10 years ago
Closed 10 years ago
#10623 closed enhancement (fixed)
Move integer factorization functions to a separate file
Reported by: | aapitzsch | Owned by: | tbd |
---|---|---|---|
Priority: | critical | Milestone: | sage-4.7.1 |
Component: | factorization | Keywords: | |
Cc: | spancratz | Merged in: | sage-4.7.1.alpha2 |
Authors: | André Apitzsch | Reviewers: | David Kirkby, Mariah Lenox |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Depends on #5945.
Attachments (1)
Change History (7)
comment:1 Changed 10 years ago by
- Status changed from new to needs_review
- Summary changed from Move integer factorization functions to a separat file to Move integer factorization functions to a separate file
Changed 10 years ago by
comment:2 Changed 10 years ago by
- Reviewers set to David Kirkby
comment:3 Changed 10 years ago by
- Dependencies set to #5945
comment:4 Changed 10 years ago by
- Reviewers changed from David Kirkby to David Kirkby, Mariah Lenox
- Status changed from needs_review to positive_review
I applied the patch to sage-4.7.rc2, did 'sage -b', and then ran 'make testlong'. All tests passed. Positive review.
comment:5 Changed 10 years ago by
- Dependencies #5945 deleted
- Milestone changed from sage-4.7 to sage-4.7.1
- Priority changed from major to critical
comment:6 Changed 10 years ago by
- Merged in set to sage-4.7.1.alpha2
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
I verified the examples using Mathematica, but can't comment on the rest of the ticket.
I think it's useful to indicate how the results are known to be correct. In this case I agree they are.
Dave