Opened 12 years ago

Closed 12 years ago

#10623 closed enhancement (fixed)

Move integer factorization functions to a separate file

Reported by: aapitzsch Owned by: tbd
Priority: critical Milestone: sage-4.7.1
Component: factorization Keywords:
Cc: spancratz Merged in: sage-4.7.1.alpha2
Authors: André Apitzsch Reviewers: David Kirkby, Mariah Lenox
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

See comment:14:ticket:1145.

Depends on #5945.

Attachments (1)

trac_10623.patch​ (13.9 KB) - added by aapitzsch 12 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 12 years ago by aapitzsch

Status: new → needs_review
Summary: Move integer factorization functions to a separat file → Move integer factorization functions to a separate file

Changed 12 years ago by aapitzsch

Attachment: trac_10623.patch​ added

comment:2 Changed 12 years ago by drkirkby

Reviewers: → David Kirkby

I verified the examples using Mathematica, but can't comment on the rest of the ticket.

I think it's useful to indicate how the results are known to be correct. In this case I agree they are.

Dave

comment:3 Changed 12 years ago by robertwb

Dependencies: → #5945

comment:4 Changed 12 years ago by mariah

Reviewers: David Kirkby → David Kirkby, Mariah Lenox
Status: needs_review → positive_review

I applied the patch to sage-4.7.rc2, did 'sage -b', and then ran 'make testlong'. All tests passed. Positive review.

comment:5 Changed 12 years ago by jdemeyer

Dependencies: #5945
Milestone: sage-4.7 → sage-4.7.1
Priority: major → critical

comment:6 Changed 12 years ago by jdemeyer

Merged in: → sage-4.7.1.alpha2
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.