Opened 10 years ago
Closed 9 years ago
#10621 closed enhancement (fixed)
Make Conic class able to find points over number fields
Reported by: | mstreng | Owned by: | mhampton |
---|---|---|---|
Priority: | major | Milestone: | sage-4.8 |
Component: | number fields | Keywords: | rational point points conic quadratic form number field sd35 |
Cc: | mstreng | Merged in: | sage-4.8.alpha5 |
Authors: | Marco Streng | Reviewers: | John Cremona |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Solve conics over number fields using PARI's rnfisnorm.
This is not meant to be efficient. Future patches can deal with that (such as #11455 for those who have Magma). Magma or #11455 can be used to check correctness of tests and documentation.
On sage 4.7 or higher, no patches from other tickets are needed.
Attachments (3)
Change History (14)
Changed 10 years ago by
comment:1 Changed 10 years ago by
- Description modified (diff)
- Status changed from new to needs_work
- Work issues changed from Needs #9334, testing and probably some changes to After #9334 is finished, this patch will need testing and corrections
comment:2 Changed 10 years ago by
- Component changed from geometry to number fields
comment:3 Changed 10 years ago by
- Description modified (diff)
- Status changed from needs_work to needs_review
- Work issues After #9334 is finished, this patch will need testing and corrections deleted
comment:4 Changed 10 years ago by
- Dependencies set to #727, #2329
comment:5 Changed 10 years ago by
See also #11455, which extends this ticket.
comment:6 Changed 10 years ago by
- Dependencies #727, #2329 deleted
- Description modified (diff)
Apply to Sage 4.7 or higher (or see above for the dependencies).
Please review, a student will need #11455 in September.
comment:7 Changed 9 years ago by
- Reviewers set to John Cremona
- Status changed from needs_review to needs_work
Sorry I didn't make the September deadline...
Looks basically good, but I get some doctest failures after applying (successfully) to 4.8.alpha4:
sage -t -long devel/sage-main/sage/schemes/plane_conics/con_rational_field.py # 1 doctests failed sage -t -long devel/sage-main/sage/schemes/plane_conics/con_field.py # 2 doctests failed sage -t -long devel/sage-main/sage/schemes/plane_conics/con_number_field.py # 6 doctests failed
Mostly they are this:
File "/home/jec/sage-4.8.alpha4/local/lib/python/site-packages/sage/schemes/plane_conics/con_number_field.py", line 249, in has_rational_point pt = self.point(T*vector([KtoB(isnorm[1][0]), NameError: global name 'vector' is not defined
and also there is this:
File "/home/jec/sage-4.8.alpha4/devel/sage-main/sage/schemes/plane_conics/con_number_field.py", line 290: sage: f = (2*O).factor(); f Expected: (Fractional ideal (-a^2 - a + 1)) * (Fractional ideal (-a^2 + 2*a - 3)) Got: (Fractional ideal (-a^2 - a + 1)) * (Fractional ideal (a^2 - 2*a + 3))
which is of course trivial, and probably due to a Pari change in the interim.
Fix these and I'll give it a positive review!
comment:8 Changed 9 years ago by
- Description modified (diff)
apply 10621_conics_number_fields.patch only
comment:9 Changed 9 years ago by
- Keywords sd35 added
- Status changed from needs_work to needs_review
Changes (to con_number_field.py
only):
> + from sage.modules.free_module_element import vector < + sage: f = (2*O).factor(); f < + (Fractional ideal (-a^2 - a + 1)) * (Fractional ideal (-a^2 + 2*a - 3)) > + sage: f = (2*O).factor()
comment:10 Changed 9 years ago by
- Status changed from needs_review to positive_review
comment:11 Changed 9 years ago by
- Merged in set to sage-4.8.alpha5
- Resolution set to fixed
- Status changed from positive_review to closed
Requires #727, #2329, #9334. Then apply trac_10621_conics_over_number_fields.patch