Opened 12 years ago
Closed 11 years ago
#10621 closed enhancement (fixed)
Make Conic class able to find points over number fields
Reported by: | Marco Streng | Owned by: | mhampton |
---|---|---|---|
Priority: | major | Milestone: | sage-4.8 |
Component: | number fields | Keywords: | rational point points conic quadratic form number field sd35 |
Cc: | Marco Streng | Merged in: | sage-4.8.alpha5 |
Authors: | Marco Streng | Reviewers: | John Cremona |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Solve conics over number fields using PARI's rnfisnorm.
This is not meant to be efficient. Future patches can deal with that (such as #11455 for those who have Magma). Magma or #11455 can be used to check correctness of tests and documentation.
On sage 4.7 or higher, no patches from other tickets are needed.
Attachments (3)
Change History (14)
Changed 12 years ago by
Attachment: | trac_10621_conics_over_number_fields.patch added |
---|
comment:1 Changed 12 years ago by
Description: | modified (diff) |
---|---|
Status: | new → needs_work |
Work issues: | Needs #9334, testing and probably some changes → After #9334 is finished, this patch will need testing and corrections |
comment:2 Changed 12 years ago by
Component: | geometry → number fields |
---|
Changed 12 years ago by
Attachment: | trac_10621_conics_number_fields.patch added |
---|
apply trac_10621_conics_number_fields.patch only
comment:3 Changed 12 years ago by
Description: | modified (diff) |
---|---|
Status: | needs_work → needs_review |
Work issues: | After #9334 is finished, this patch will need testing and corrections |
comment:4 Changed 12 years ago by
Dependencies: | → #727, #2329 |
---|
comment:6 Changed 11 years ago by
Dependencies: | #727, #2329 |
---|---|
Description: | modified (diff) |
Apply to Sage 4.7 or higher (or see above for the dependencies).
Please review, a student will need #11455 in September.
comment:7 Changed 11 years ago by
Reviewers: | → John Cremona |
---|---|
Status: | needs_review → needs_work |
Sorry I didn't make the September deadline...
Looks basically good, but I get some doctest failures after applying (successfully) to 4.8.alpha4:
sage -t -long devel/sage-main/sage/schemes/plane_conics/con_rational_field.py # 1 doctests failed sage -t -long devel/sage-main/sage/schemes/plane_conics/con_field.py # 2 doctests failed sage -t -long devel/sage-main/sage/schemes/plane_conics/con_number_field.py # 6 doctests failed
Mostly they are this:
File "/home/jec/sage-4.8.alpha4/local/lib/python/site-packages/sage/schemes/plane_conics/con_number_field.py", line 249, in has_rational_point pt = self.point(T*vector([KtoB(isnorm[1][0]), NameError: global name 'vector' is not defined
and also there is this:
File "/home/jec/sage-4.8.alpha4/devel/sage-main/sage/schemes/plane_conics/con_number_field.py", line 290: sage: f = (2*O).factor(); f Expected: (Fractional ideal (-a^2 - a + 1)) * (Fractional ideal (-a^2 + 2*a - 3)) Got: (Fractional ideal (-a^2 - a + 1)) * (Fractional ideal (a^2 - 2*a + 3))
which is of course trivial, and probably due to a Pari change in the interim.
Fix these and I'll give it a positive review!
Changed 11 years ago by
Attachment: | 10621_conics_number_fields.patch added |
---|
a few fixes compared to the previous file, apply only this one
comment:8 Changed 11 years ago by
Description: | modified (diff) |
---|
apply 10621_conics_number_fields.patch only
comment:9 Changed 11 years ago by
Keywords: | sd35 added |
---|---|
Status: | needs_work → needs_review |
Changes (to con_number_field.py
only):
> + from sage.modules.free_module_element import vector < + sage: f = (2*O).factor(); f < + (Fractional ideal (-a^2 - a + 1)) * (Fractional ideal (-a^2 + 2*a - 3)) > + sage: f = (2*O).factor()
comment:10 Changed 11 years ago by
Status: | needs_review → positive_review |
---|
comment:11 Changed 11 years ago by
Merged in: | → sage-4.8.alpha5 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Requires #727, #2329, #9334. Then apply trac_10621_conics_over_number_fields.patch