Opened 11 years ago
Closed 10 years ago
#10617 closed enhancement (fixed)
Make polynomial over ZZ call FLINT for composition and evaluation
Reported by: | spancratz | Owned by: | AlexGhitza |
---|---|---|---|
Priority: | major | Milestone: | sage-5.1 |
Component: | basic arithmetic | Keywords: | polynomial arithmetic |
Cc: | mhansen | Merged in: | sage-5.1.beta5 |
Authors: | Sebastian Pancratz | Reviewers: | Tom Boothby, Mike Hansen |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
In Sage 4.6.0,
sage: R.<x> = ZZ[] sage: f = R.random_element(200) sage: g = R.random_element(200) sage: %time _ = f(g) CPU times: user 102.61 s, sys: 4.47 s, total: 107.08 s Wall time: 107.27 s
Apply only trac_10617.patch
Attachments (1)
Change History (11)
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
Apply only trac-10617.2.patch
--- I forgot to mark the "replace" box. Sebastian
comment:3 Changed 11 years ago by
Actually, I just had to re-upload the patch and this time I did remember to tick the "replace" box, so it's now
trac-10617.patch
again. Sebastian
comment:4 Changed 11 years ago by
- Status changed from new to needs_review
comment:6 Changed 11 years ago by
- Status changed from positive_review to needs_work
- Please fill in your real names as Author/Reviewer?
- The patch should be a proper hg changeset, i.e. created with
hg export tip
instead ofhg diff
. - The patch should be rebased to sage-4.6.2.alpha1.
comment:7 Changed 10 years ago by
- Cc mhansen added
We should update this quickly after updating FLINT in Sage.
Changed 10 years ago by
comment:8 Changed 10 years ago by
- Reviewers set to Mike Hansen
- Status changed from needs_work to needs_review
Apply only trac_10617.patch
comment:9 Changed 10 years ago by
- Description modified (diff)
- Reviewers changed from Mike Hansen to Tom Boothby, Mike Hansen
- Status changed from needs_review to positive_review
I've rebased the patch, and everything looks good.
comment:10 Changed 10 years ago by
- Merged in set to sage-5.1.beta5
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
With the ticket applied,
We also note the change in runtime taken for evaluating a polynomial at an integer. With a vanilla 4.6.0,