Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#10609 closed defect (fixed)

tachyon fails with .ac in hostname

Reported by: wjp Owned by: was
Priority: major Milestone: sage-4.6.2
Component: interfaces Keywords:
Cc: Merged in: sage-4.6.2.alpha1
Authors: Willem Jan Palenstijn Reviewers: Volker Braun
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

When your hostname contains the string .ac, the name of a temporary file will also contain this string, and then tachyon's automatic file format detection will assume the input file is an ac3d file rather than the default tachyon scene file.

This causes tachyon to fail entirely on my machine in the domain .ua.ac.be and is likely also the cause of http://www.mail-archive.com/sage-support@googlegroups.com/msg11743.html .

The error message shown is "Unknown version of AC3D Model File Format".

The relevant lines in tachyon's main.c are

    else if (strstr(filename, ".ac") || strstr(filename, ".AC")) {
      rc = ParseAC3D(filename, scene); /* Must be an AC3D file */
    }

Attachments (1)

10609_tachyon_extension.patch (1.3 KB) - added by wjp 10 years ago.

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by wjp

comment:1 Changed 10 years ago by wjp

  • Status changed from new to needs_review

Updated SPKG, based on the one in #5281, at:

http://www.math.leidenuniv.nl/~wpalenst/sage/tachyon-0.98.9.p1.spkg

For convenience, the applied patch is attached to this ticket too.

comment:2 Changed 10 years ago by wjp

  • Authors set to Willem Jan Palenstijn

comment:3 Changed 10 years ago by fbissey

Looks good to me. I would have done something similar. Did you forward that upstream?

comment:4 Changed 10 years ago by wjp

  • Report Upstream changed from N/A to Reported upstream. Little or no feedback.

Yes, I did.

comment:5 Changed 10 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

Awesome!#@#@

comment:6 Changed 10 years ago by wjp

  • Report Upstream changed from Reported upstream. Little or no feedback. to Reported upstream. Developers acknowledge bug.

comment:7 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.6.2.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:8 Changed 10 years ago by wjp

  • Report Upstream changed from Reported upstream. Developers acknowledge bug. to Fixed upstream, but not in a stable release.
Note: See TracTickets for help on using tickets.