#10609 closed defect (fixed)
tachyon fails with .ac in hostname
Reported by: | wjp | Owned by: | was |
---|---|---|---|
Priority: | major | Milestone: | sage-4.6.2 |
Component: | interfaces | Keywords: | |
Cc: | Merged in: | sage-4.6.2.alpha1 | |
Authors: | Willem Jan Palenstijn | Reviewers: | Volker Braun |
Report Upstream: | Fixed upstream, but not in a stable release. | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
When your hostname contains the string .ac
, the name of a temporary file will also contain this string, and then tachyon's automatic file format detection will assume the input file is an ac3d file rather than the default tachyon scene file.
This causes tachyon to fail entirely on my machine in the domain .ua.ac.be
and is likely also the cause of http://www.mail-archive.com/sage-support@googlegroups.com/msg11743.html .
The error message shown is "Unknown version of AC3D Model File Format
".
The relevant lines in tachyon's main.c are
else if (strstr(filename, ".ac") || strstr(filename, ".AC")) { rc = ParseAC3D(filename, scene); /* Must be an AC3D file */ }
Attachments (1)
Change History (9)
Changed 11 years ago by
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
comment:2 Changed 11 years ago by
comment:3 Changed 11 years ago by
Looks good to me. I would have done something similar. Did you forward that upstream?
comment:4 Changed 11 years ago by
- Report Upstream changed from N/A to Reported upstream. Little or no feedback.
Yes, I did.
comment:5 Changed 11 years ago by
- Reviewers set to Volker Braun
- Status changed from needs_review to positive_review
Awesome!#@#@
comment:6 Changed 11 years ago by
- Report Upstream changed from Reported upstream. Little or no feedback. to Reported upstream. Developers acknowledge bug.
comment:7 Changed 11 years ago by
- Merged in set to sage-4.6.2.alpha1
- Resolution set to fixed
- Status changed from positive_review to closed
comment:8 Changed 11 years ago by
- Report Upstream changed from Reported upstream. Developers acknowledge bug. to Fixed upstream, but not in a stable release.
Updated SPKG, based on the one in #5281, at:
http://www.math.leidenuniv.nl/~wpalenst/sage/tachyon-0.98.9.p1.spkg
For convenience, the applied patch is attached to this ticket too.