Opened 11 years ago

Closed 10 years ago

#10603 closed defect (fixed)

DisjointUnionEnumeratedSets should not always define Element and _element_constructor_

Reported by: hivert Owned by: hivert
Priority: major Milestone: sage-5.0
Component: combinatorics Keywords: DisjointUnionEnumeratedSets, Element, Cernay2012
Cc: sage-combinat Merged in: sage-5.0.beta6
Authors: Florent Hivert Reviewers: Nicolas M. Thiéry
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

When the argument facade is set to True the attributes Element and _element_constructor_ are defined by the class DisjointUnionEnumeratedSets. This is a bad idea because it prevents a super class like a category to define them. The following patch fixes this problem.

Attachments (1)

trac_10603-union_enumset_elconstr_fix-fh.patch​ (9.4 KB) - added by hivert 10 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 11 years ago by hivert

  • Status changed from new to needs_work

I leave the patch as needs work because there is some dependency on another non finished patch (#10193).

comment:2 Changed 10 years ago by hivert

  • Dependencies set to #10193
  • Owner changed from sage-combinat to hivert

comment:3 Changed 10 years ago by hivert

  • Status changed from needs_work to needs_review

comment:4 Changed 10 years ago by chapoton

Hello, you should add ticket number #10193 to the first line of the commit message.

comment:5 Changed 10 years ago by hivert

  • Keywords Cenay2012 added

comment:6 Changed 10 years ago by hivert

  • Keywords Cernay2012 added; Cenay2012 removed

comment:7 Changed 10 years ago by hivert

  • Dependencies #10193 deleted

Removed (trivial) dependency to #10193

Changed 10 years ago by hivert

comment:8 Changed 10 years ago by nthiery

  • Reviewers changed from Nicolas Thiéry to Nicolas M. Thiéry
  • Status changed from needs_review to positive_review

Review done on the Sage-Combinat queue. All test pass. Positive review!

comment:9 Changed 10 years ago by jdemeyer

  • Merged in set to sage-5.0.beta6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.