Opened 12 years ago
Closed 11 years ago
#10603 closed defect (fixed)
DisjointUnionEnumeratedSets should not always define Element and _element_constructor_
| Reported by: | hivert | Owned by: | hivert |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.0 |
| Component: | combinatorics | Keywords: | DisjointUnionEnumeratedSets, Element, Cernay2012 |
| Cc: | sage-combinat | Merged in: | sage-5.0.beta6 |
| Authors: | Florent Hivert | Reviewers: | Nicolas M. Thiéry |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
GitHub link to the corresponding issue
Description
When the argument facade is set to True the attributes Element and _element_constructor_ are defined by the class DisjointUnionEnumeratedSets. This is a bad idea because it prevents a super class like a category to define them. The following patch fixes this problem.
Attachments (1)
Change History (10)
comment:1 Changed 12 years ago by
| Status: | new → needs_work |
|---|
comment:2 Changed 12 years ago by
| Dependencies: | → #10193 |
|---|---|
| Owner: | changed from sage-combinat to hivert |
comment:3 Changed 12 years ago by
| Status: | needs_work → needs_review |
|---|
comment:4 Changed 12 years ago by
Hello, you should add ticket number #10193 to the first line of the commit message.
comment:5 Changed 11 years ago by
| Keywords: | Cenay2012 added |
|---|
comment:6 Changed 11 years ago by
| Keywords: | Cernay2012 added; Cenay2012 removed |
|---|
Changed 11 years ago by
| Attachment: | trac_10603-union_enumset_elconstr_fix-fh.patch added |
|---|
comment:8 Changed 11 years ago by
| Reviewers: | Nicolas Thiéry → Nicolas M. Thiéry |
|---|---|
| Status: | needs_review → positive_review |
Review done on the Sage-Combinat queue. All test pass. Positive review!
comment:9 Changed 11 years ago by
| Merged in: | → sage-5.0.beta6 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
I leave the patch as needs work because there is some dependency on another non finished patch (#10193).