Opened 11 years ago

Last modified 7 years ago

#10602 new defect

A lot of functions still use a default of proof=True but should depend on the global proof settings

Reported by: mderickx Owned by: jason
Priority: trivial Milestone:
Component: misc Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The summary sais it all. Below is a list of functions which do it wrong>

search_def("proof=True")
libs/ntl/ntl_ZZX.pyx:979:        default is proof=True), then this function may use a
libs/ntl/ntl_ZZX.pyx:1004:        default is proof=True), then this function may use a
matrix/matrix_integer_dense_hnf.py:81:def det_given_divisor(A, d, proof=True, stabilize=2):
matrix/matrix_integer_dense_hnf.py:175:def det_padic(A, proof=True, stabilize=2):
matrix/matrix_integer_dense_hnf.py:947:def hnf(A, include_zero_rows=True, proof=True):
matrix/matrix_integer_dense_hnf.py:1018:def hnf_with_transformation(A, proof=True):
matrix/matrix_integer_dense_hnf.py:1116:def sanity_checks(times=50, n=8, m=5, proof=True, stabilize=2, check_using_magma = True):
matrix/matrix_integer_dense_saturation.py:13:def p_saturation(A, p, proof=True):
matrix/matrix_integer_dense_saturation.py:168:def saturation(A, proof=True, p=0, max_dets=5):
matrix/matrix_integer_dense_saturation.py:268:def index_in_saturation(A, proof=True):
matrix/matrix_rational_sparse.pyx:469:    def echelonize(self, height_guess=None, proof=True, **kwds):
matrix/matrix_rational_sparse.pyx:539:    def _echelonize_multimodular(self, height_guess=None, proof=True, **kwds):
matrix/matrix_rational_sparse.pyx:554:    def _echelon_form_multimodular(self, height_guess=None, proof=True):
rings/integer.pyx:3084:    def factor(self, algorithm='pari', proof=True, limit=None):
rings/integer.pyx:3139:    def _factor_cunningham(self, proof=True):
rings/integer.pyx:4358:           default is proof=True
rings/integer_ring.pyx:1057:def factor(n, algorithm='pari', proof=True):
rings/quotient_ring.py:434:    def is_integral_domain(self, proof=True):
rings/number_field/class_group.py:38:    def __init__(self, invariants, names, number_field, gens, proof=True):
rings/number_field/number_field.py:2732:    def S_class_group(self, S, proof=True):
rings/number_field/number_field.py:2764:    def S_units(self, S, proof=True):
rings/number_field/number_field.py:2798:    def _S_class_group_and_units(self, S, proof=True):
rings/number_field/number_field.py:2848:    def selmer_group(self, S, m, proof=True):
rings/number_field/unit_group.py:125:    def __init__(self, number_field, proof=True):
rings/polynomial/multi_polynomial_element.py:1416:    def factor(self, proof=True):
rings/polynomial/multi_polynomial_ideal.py:1866:    def variety(self, ring=None, proof=True):
rings/polynomial/polynomial_integer_dense_flint.pyx:939:    def discriminant(self, proof=True):
rings/polynomial/polynomial_integer_dense_flint.pyx:1230:    def resultant(self, other, proof=True):
rings/polynomial/polynomial_integer_dense_ntl.pyx:784:    def discriminant(self, proof=True):
rings/polynomial/polynomial_integer_dense_ntl.pyx:1042:    def resultant(self, other, proof=True):
rings/polynomial/polynomial_quotient_ring.py:616:    def S_class_group(self, S, proof=True):
rings/polynomial/polynomial_quotient_ring.py:708:    def class_group(self, proof=True):
rings/polynomial/polynomial_quotient_ring.py:793:    def S_units(self, S, proof=True):
rings/polynomial/polynomial_quotient_ring.py:851:    def units(self, proof=True):
rings/polynomial/polynomial_quotient_ring.py:908:    def _S_class_group_and_units(self, S, proof=True):
rings/polynomial/polynomial_quotient_ring.py:1031:    def selmer_group(self, S, m, proof=True):
rings/polynomial/toy_variety.py:224:def triangular_factorization(B, n=-1, proof=True):
schemes/elliptic_curves/ell_finite_field.py:1571:    def is_isogenous(self, other, field=None, proof=True):
schemes/elliptic_curves/ell_finite_field.py:1692:    def is_supersingular(self, proof=True):
schemes/elliptic_curves/ell_finite_field.py:1727:    def is_ordinary(self, proof=True):
schemes/elliptic_curves/ell_finite_field.py:1882:def is_j_supersingular(j, proof=True):
schemes/elliptic_curves/ell_number_field.py:1838:    def is_isogenous(self, other, proof=True, maxnorm=100):
schemes/elliptic_curves/ell_rational_field.py:3974:    def is_isogenous(self, other, proof=True, maxp=200):
sets/primes.py:57:    def __classcall__(cls, proof=True):
symbolic/expression.pyx:1718:    def test_relation(self, int ntests=20, domain=None, proof=True):

Change History (1)

comment:1 Changed 7 years ago by jdemeyer

  • Component changed from interfaces to misc
  • Owner changed from was to jason
Note: See TracTickets for help on using tickets.