Opened 11 years ago
Closed 11 years ago
#10600 closed defect (fixed)
fix bug in eliminate_linear_variables() + return reductors used
Reported by: | malb | Owned by: | mvngu |
---|---|---|---|
Priority: | major | Milestone: | sage-4.6.2 |
Component: | cryptography | Keywords: | |
Cc: | msoos | Merged in: | sage-4.6.2.alpha2 |
Authors: | Martin Albrecht | Reviewers: | Mate Soos |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
This shouldn't return an empty list:
sage: B.<a,b,c,d> = BooleanPolynomialRing() sage: l = [a + b + d, a + b + c] sage: F = mq.MPolynomialSystem(l) sage: F.eliminate_linear_variables() Polynomial System with 0 Polynomials in 0 Variables
Also, it'd be nice to get the list of polynomials used for elimination as well.
Attachments (1)
Change History (8)
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
comment:2 Changed 11 years ago by
- Status changed from needs_review to needs_work
Changed 11 years ago by
comment:3 Changed 11 years ago by
I assume you meant 1+3 and I chose this option. (thanks for spotting that I included 2 by accident). If you're happy with my change, you should change the status to "positive review".
comment:4 Changed 11 years ago by
- Status changed from needs_work to positive_review
Now it is performing what says in its description. I would still separate the fix from the enhancement, I think, or maybe I am getting something wrong here. In any case, the patch seems OK
comment:5 Changed 11 years ago by
- Cc msoos added
msoos: add your real name on this ticket as Reviewer. Also you should add yourself to http://trac.sagemath.org/sage_trac/#AccountNamesmappedtoRealNames
comment:6 Changed 11 years ago by
- Reviewers set to Mate Soos
comment:7 Changed 11 years ago by
- Merged in set to sage-4.6.2.alpha2
- Resolution set to fixed
- Status changed from positive_review to closed
I think we should cut this patch into 2 or (preferably) to 3 pieces:
1) Add return_reductors enhancement
2) Add Warning message for slimgb
3) fix for "Polynomial System with 0 Polynomials in 0 Variables"
Maybe 2+3 could be made into one patch, though I wouldn't prefer it.