Opened 9 years ago

Closed 9 years ago

#10593 closed enhancement (fixed)

Replace __getslice__ with functionality in __getitem__ in ContinuedFraction

Reported by: aapitzsch Owned by: was
Priority: minor Milestone: sage-4.6.2
Component: number theory Keywords:
Cc: Merged in: sage-4.6.2.alpha3
Authors: André Apitzsch Reviewers: Robert Bradshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

__getslice__ is deprecated.

The attached patch also fixes

sage: a = continued_fraction(pi)
sage: type(a[2:5])
<class 'sage.rings.contfrac.ContinuedFraction'>
sage: type(a[2:5:1])
<type 'list'>

Attachments (1)

trac_10593.patch (1.5 KB) - added by aapitzsch 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by aapitzsch

comment:1 Changed 9 years ago by aapitzsch

  • Status changed from new to needs_review

comment:2 Changed 9 years ago by robertwb

  • Status changed from needs_review to positive_review

comment:3 Changed 9 years ago by jdemeyer

  • Milestone set to sage-4.6.2
  • Reviewers set to Robert Bradshaw

comment:4 Changed 9 years ago by jdemeyer

  • Merged in set to sage-4.6.2.alpha3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.