Opened 12 years ago

Closed 12 years ago

#10593 closed enhancement (fixed)

Replace __getslice__ with functionality in __getitem__ in ContinuedFraction

Reported by: aapitzsch Owned by: William Stein
Priority: minor Milestone: sage-4.6.2
Component: number theory Keywords:
Cc: Merged in: sage-4.6.2.alpha3
Authors: André Apitzsch Reviewers: Robert Bradshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

__getslice__ is deprecated.

The attached patch also fixes

sage: a = continued_fraction(pi)
sage: type(a[2:5])
<class 'sage.rings.contfrac.ContinuedFraction'>
sage: type(a[2:5:1])
<type 'list'>

Attachments (1)

trac_10593.patch (1.5 KB) - added by aapitzsch 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by aapitzsch

Attachment: trac_10593.patch added

comment:1 Changed 12 years ago by aapitzsch

Status: newneeds_review

comment:2 Changed 12 years ago by Robert Bradshaw

Status: needs_reviewpositive_review

comment:3 Changed 12 years ago by Jeroen Demeyer

Milestone: sage-4.6.2
Reviewers: Robert Bradshaw

comment:4 Changed 12 years ago by Jeroen Demeyer

Merged in: sage-4.6.2.alpha3
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.