Opened 11 years ago
Closed 11 years ago
#10547 closed defect (fixed)
DeBruijn digraph fixes
Reported by: | eviatarbach | Owned by: | jason, ncohen, rlm |
---|---|---|---|
Priority: | major | Milestone: | sage-4.6.2 |
Component: | graph theory | Keywords: | |
Cc: | Merged in: | sage-4.6.2.alpha1 | |
Authors: | Eviatar Bach | Reviewers: | Nathann Cohen |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
This patch fixes some problems with the DeBruijn? digraph. Specifically, it changes alphabets to start with 0 (as is conventional), switches the variables k and n (again, convention) and removes the "words: " from the labels.
Attachments (1)
Change History (8)
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
comment:2 Changed 11 years ago by
- Status changed from needs_review to needs_work
comment:3 Changed 11 years ago by
- Status changed from needs_work to needs_review
Hello,
Thank you, I did not know about this method! The new patch is uploaded.
Cheers!
comment:4 Changed 11 years ago by
- Status changed from needs_review to positive_review
Well, it was the only fault I could find in this patch ! Thank you for fixing this ! :-)
Nathann
comment:5 Changed 11 years ago by
And thank you for reviewing!
By the way, since I'm not familiar with the review system, what are the requirements for inclusion? Does the patch get implemented once it has a positive review?
comment:6 Changed 11 years ago by
- Milestone changed from sage-4.6.1 to sage-4.6.2
- Reviewers set to Nathann Cohen
comment:7 Changed 11 years ago by
- Merged in set to sage-4.6.2.alpha1
- Resolution set to fixed
- Status changed from positive_review to closed
Hello !!
Could you use
w.string_rep()
instead or
repr(w)[6:]
? This would prevent us from some trouble if the
repr
method from words is changed later on
:-)
Nathann