Opened 10 years ago

Closed 10 years ago

#10547 closed defect (fixed)

DeBruijn digraph fixes

Reported by: eviatarbach Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-4.6.2
Component: graph theory Keywords:
Cc: Merged in: sage-4.6.2.alpha1
Authors: Eviatar Bach Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This patch fixes some problems with the DeBruijn? digraph. Specifically, it changes alphabets to start with 0 (as is conventional), switches the variables k and n (again, convention) and removes the "words: " from the labels.

Attachments (1)

15057.patch​ (3.3 KB) - added by eviatarbach 10 years ago.
New patch

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by eviatarbach

  • Status changed from new to needs_review

comment:2 Changed 10 years ago by ncohen

  • Status changed from needs_review to needs_work

Hello !!

Could you use w.string_rep() instead or repr(w)[6:] ? This would prevent us from some trouble if the repr method from words is changed later on :-)

Nathann

comment:3 Changed 10 years ago by eviatarbach

  • Status changed from needs_work to needs_review

Hello,

Thank you, I did not know about this method! The new patch is uploaded.

Cheers!

Changed 10 years ago by eviatarbach

New patch

comment:4 Changed 10 years ago by ncohen

  • Status changed from needs_review to positive_review

Well, it was the only fault I could find in this patch ! Thank you for fixing this ! :-)

Nathann

comment:5 Changed 10 years ago by eviatarbach

And thank you for reviewing!

By the way, since I'm not familiar with the review system, what are the requirements for inclusion? Does the patch get implemented once it has a positive review?

comment:6 Changed 10 years ago by jdemeyer

  • Milestone changed from sage-4.6.1 to sage-4.6.2
  • Reviewers set to Nathann Cohen

comment:7 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.6.2.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.