Changes between Initial Version and Version 4 of Ticket #10543


Ignore:
Timestamp:
02/03/11 02:02:03 (9 years ago)
Author:
rbeezer
Comment:

Hi Tom,

Thanks for the catch on making a copy of the matrix. Not sure what I was thinking just then. Your changes look real good to me.

I think your patch includes my changes and yours mixed together. And some changes get applied in the echelonize routine (which really had me scratching my head). I've tried to split out your changes and have placed a new patch that I belive has just your changes. Except there were some double-colons needed, including one I'd forgotten. You should give the revised patch a real close look.

Can you test the whole package? If so, I think you'd be clear to finalize the review if everything looks OK. It'll need my original patch and then the rebased reviewer patch. I have tested the pair against the two affected files and viewed the HTML documentation, and that much looks good.

Thanks for taking a look at this one and making a fix.

Rob

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10543

    • Property Status changed from new to needs_review
    • Property Reviewers changed from to Tom Coates
    • Property Authors changed from to Rob Beezer
  • Ticket #10543 – Description

    initial v4  
    1313
    1414See http://groups.google.com/group/sage-devel/browse_thread/thread/ef90d24da0ee704c
     15
     16Apply
     17
     18trac_10543-rational-echelon-form-immutable.patch, trac_10543-reviewer-rebased.patch