Opened 9 years ago

Closed 9 years ago

#10536 closed enhancement (fixed)

Add vector conjugation

Reported by: rbeezer Owned by: jason, was
Priority: major Milestone: sage-4.7
Component: linear algebra Keywords:
Cc: kcrisman Merged in: sage-4.7.alpha3
Authors: Rob Beezer Reviewers: Felix Lawrence
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by flawrence)

As for matrices, this method conjugates every element of a vector, by appealing to the conjugate() method of the base ring. This is a prelude to a proper inner product for vectors over the complex numbers.

For the record, making a list of new entries and creating a new vector, is much faster than making a copy and changing it in-place.

To the release manager: apply trac_10536-vector-conjugation-v3.patch only.

Attachments (3)

trac_10536-vector-conjugation.patch (2.4 KB) - added by rbeezer 9 years ago.
trac_10536-vector-conjugation-v2.patch (3.8 KB) - added by rbeezer 9 years ago.
trac_10536-vector-conjugation-v3.patch (3.9 KB) - added by rbeezer 9 years ago.

Download all attachments as: .zip

Change History (12)

Changed 9 years ago by rbeezer

comment:1 Changed 9 years ago by rbeezer

  • Authors set to Rob Beezer
  • Status changed from new to needs_review

comment:2 Changed 9 years ago by rbeezer

  • Status changed from needs_review to needs_work

Parents aren't being preserved correctly. New patch in just a bit.

Changed 9 years ago by rbeezer

comment:3 Changed 9 years ago by rbeezer

  • Status changed from needs_work to needs_review

This now depends on #10537, so that sparse vectors behave properly once rebuilt after being manipulated.

Depends on #10537

Apply trac_10536-vector-conjugation-v2.patch

comment:4 Changed 9 years ago by kcrisman

  • Cc kcrisman added

Changed 9 years ago by rbeezer

comment:5 Changed 9 years ago by rbeezer

A block of doctests slipped through without any output. v3 patch corrects that, and is the only patch necessary to apply.

Apply: trac_10536-vector-conjugation-v3.patch

comment:6 Changed 9 years ago by flawrence

  • Description modified (diff)
  • Status changed from needs_review to positive_review

It makes sense, works, passes doctests, and is well documented. Positive review.

comment:7 Changed 9 years ago by flawrence

  • Reviewers set to Felix Lawrence

comment:8 Changed 9 years ago by rbeezer

Hi Felix,

Thanks for the reviews - they are a big help!

Rob

comment:9 Changed 9 years ago by jdemeyer

  • Merged in set to sage-4.7.alpha3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.