Opened 12 years ago
Closed 12 years ago
#10536 closed enhancement (fixed)
Add vector conjugation
| Reported by: | rbeezer | Owned by: | jason, was |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.7 |
| Component: | linear algebra | Keywords: | |
| Cc: | kcrisman | Merged in: | sage-4.7.alpha3 |
| Authors: | Rob Beezer | Reviewers: | Felix Lawrence |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
As for matrices, this method conjugates every element of a vector, by appealing to the conjugate() method of the base ring. This is a prelude to a proper inner product for vectors over the complex numbers.
For the record, making a list of new entries and creating a new vector, is much faster than making a copy and changing it in-place.
To the release manager: apply trac_10536-vector-conjugation-v3.patch only.
Attachments (3)
Change History (12)
Changed 12 years ago by
| Attachment: | trac_10536-vector-conjugation.patch added |
|---|
comment:1 Changed 12 years ago by
| Authors: | → Rob Beezer |
|---|---|
| Status: | new → needs_review |
comment:2 Changed 12 years ago by
| Status: | needs_review → needs_work |
|---|
Changed 12 years ago by
| Attachment: | trac_10536-vector-conjugation-v2.patch added |
|---|
comment:3 Changed 12 years ago by
| Status: | needs_work → needs_review |
|---|
comment:4 Changed 12 years ago by
| Cc: | kcrisman added |
|---|
Changed 12 years ago by
| Attachment: | trac_10536-vector-conjugation-v3.patch added |
|---|
comment:5 Changed 12 years ago by
A block of doctests slipped through without any output. v3 patch corrects that, and is the only patch necessary to apply.
Apply: trac_10536-vector-conjugation-v3.patch
comment:6 Changed 12 years ago by
| Description: | modified (diff) |
|---|---|
| Status: | needs_review → positive_review |
It makes sense, works, passes doctests, and is well documented. Positive review.
comment:7 Changed 12 years ago by
| Reviewers: | → Felix Lawrence |
|---|
comment:9 Changed 12 years ago by
| Merged in: | → sage-4.7.alpha3 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Parents aren't being preserved correctly. New patch in just a bit.