Opened 9 years ago

Closed 9 years ago

#10535 closed enhancement (fixed)

A column-oriented matrix constructor

Reported by: rbeezer Owned by: jason, was
Priority: minor Milestone: sage-4.6.2
Component: linear algebra Keywords:
Cc: ddrake, jason Merged in: sage-4.6.2.alpha3
Authors: Rob Beezer, Jason Grout Reviewers: Dan Drake
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Sage likes rows better than columns. This constructor follows suit, but then takes a transpose. So if input entries are given as a list of lists, or a list of vectors, the inner lists get turned into columns when it is finished.

Inputs are just like for the matrix() constructor, except dimensions effectively get swapped around. When giving just one dimension, it will be the number of columns, which is perhaps as it should be.

Original discussion in the vicinity of http://groups.google.com/group/sage-devel/msg/77f1cbd7807bdb89

Attachments (1)

trac_10535-column-matrix_constructor.patch (4.0 KB) - added by rbeezer 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by rbeezer

comment:1 Changed 9 years ago by rbeezer

  • Authors set to Rob Beezer, Jason Grout
  • Status changed from new to needs_review

comment:2 follow-up: Changed 9 years ago by ddrake

  • Status changed from needs_review to positive_review

This looks good to me. I don't know why the patchbot couldn't apply the patch; it works fine for me in 4.6.1.rc0. Positive review here.

comment:3 in reply to: ↑ 2 Changed 9 years ago by rbeezer

Replying to ddrake:

This looks good to me. I don't know why the patchbot couldn't apply the patch; it works fine for me in 4.6.1.rc0. Positive review here.

Thanks, Dan. (That was fast.)

I built this against a clean 4.6.1.alpha3 so I wonder too why it won't apply. I was going to add the right comments for the patchbot to find it, but my understanding was that with just one patch, that's what would get used. Hmmm.

Rob

comment:4 Changed 9 years ago by rbeezer

  • Milestone set to sage-4.6.2
  • Reviewers set to Dan Drake

comment:5 Changed 9 years ago by jdemeyer

  • Merged in set to sage-4.6.2.alpha3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.