Opened 6 years ago

Closed 6 years ago

#10518 closed enhancement (fixed)

Add dot2tex as optional spkg

Reported by: nthiery Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-4.6.2
Component: packages: optional Keywords: graphviz
Cc: sage-combinat Merged in:
Authors: Nicolas M. Thiéry Reviewers: Pablo Angulo
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Title says it all. A candidate spkg is available from #7004.

Change History (5)

comment:1 Changed 6 years ago by nthiery

  • Status changed from new to needs_review

comment:2 follow-up: Changed 6 years ago by pang

  • Status changed from needs_review to positive_review

I've inspected the package and it looks fine. I've installed it with no warning.

I've tested it, and it works on the proposed examples. It fails to compile latex plots of some graphs with non-numeric labels, but this is unrelated to the package IMHO. The fix would be to either generate better dot code for those graphs, or configure the latex environment better or in dot2tex itself. I don't really know and will report a bug when I research a bit more.

Finally, testing the library after installing the spkg in a 4.6.1 install that I just updated I got one error that seems completely unrelated (on "devel/sage/sage/tests/cmdline.py"). A fresh install also fails on that test.

I'd say this is enough for a positive review, but be my guest.

comment:3 in reply to: ↑ 2 Changed 6 years ago by nthiery

  • Milestone set to sage-4.6.2
  • Reviewers set to Pablo Angulo

Hi Pablo!

Thanks for the review!

Replying to pang:

I've inspected the package and it looks fine. I've installed it with no warning.

I've tested it, and it works on the proposed examples. It fails to compile latex plots of some graphs with non-numeric labels, but this is unrelated to the package IMHO. The fix would be to either generate better dot code for those graphs, or configure the latex environment better or in dot2tex itself. I don't really know and will report a bug when I research a bit more.

I am curious! Feel free to send me an example.

comment:4 Changed 6 years ago by jdemeyer

  • Component changed from graph theory to optional packages

comment:5 Changed 6 years ago by jdemeyer

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.