Opened 7 years ago

Closed 7 years ago

#10499 closed defect (fixed)

magma_free interface is broken

Reported by: goodok.alex Owned by: was
Priority: minor Milestone: sage-4.6.2
Component: interfaces Keywords: magma_free
Cc: Merged in: sage-4.6.2.alpha1
Authors: Alexey U. Gudchenko Reviewers: Aly Deines
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

As the layout of Magma's website have changed, the code for magma_free() should be updated.

Thread of "sage-support" mail-list https://groups.google.com/group/sage-support/browse_thread/thread/5cecd191bbb3caed/9414b467d9655bf5?hl=en&lnk=gst&q=magma_free#9414b467d9655bf5

Attachments (2)

trac_10499_fix_magma_free.patch (2.2 KB) - added by goodok.alex 7 years ago.
trac_10499_fix_broken_magma_free_interface.patch (2.3 KB) - added by goodok.alex 7 years ago.
relative to sage-4.6.1.rc0

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by goodok.alex

  • Status changed from new to needs_review

The attached patch updates the interface.

Changed 7 years ago by goodok.alex

comment:2 Changed 7 years ago by goodok.alex

Magma's website have changed once more again, new patch attached.

Changed 7 years ago by goodok.alex

relative to sage-4.6.1.rc0

comment:3 follow-up: Changed 7 years ago by goodok.alex

  • Milestone set to sage-4.6.1

added patch relative to sage-4.6.1.rc0

The first patch was created relative to sage-4.6, but there is no essential difference.

comment:4 in reply to: ↑ 3 Changed 7 years ago by aly.deines

  • Status changed from needs_review to positive_review

Replying to goodok.alex:

added patch relative to sage-4.6.1.rc0

The first patch was created relative to sage-4.6, but there is no essential difference.

It works for me on sage-4.6.1.rc1.

comment:5 Changed 7 years ago by jdemeyer

  • Milestone changed from sage-4.6.1 to sage-4.6.2

comment:6 Changed 7 years ago by aly.deines

  • Reviewers set to Aly Deines

comment:7 follow-up: Changed 7 years ago by jdemeyer

  • Status changed from positive_review to needs_info

goodok.alex: add you real name as Author of this ticket and also add yourself to http://trac.sagemath.org/sage_trac/#AccountNamesmappedtoRealNames.

comment:8 in reply to: ↑ 7 Changed 7 years ago by goodok.alex

  • Authors set to Alexey U. Gudchenko

Replying to jdemeyer:

goodok.alex: add you real name as Author of this ticket and also add yourself to http://trac.sagemath.org/sage_trac/#AccountNamesmappedtoRealNames.

comment:9 Changed 7 years ago by jdemeyer

  • Status changed from needs_info to needs_review

comment:10 Changed 7 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:11 Changed 7 years ago by jdemeyer

  • Merged in set to sage-4.6.2.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.