Opened 10 years ago

Closed 10 years ago

#10498 closed defect (fixed)

fix inject_coefficients for toric varieties

Reported by: novoselt Owned by: AlexGhitza
Priority: major Milestone: sage-4.6.2
Component: algebraic geometry Keywords:
Cc: vbraun Merged in: sage-4.6.2.alpha2
Authors: Andrey Novoseltsev Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by vbraun)

Because it only pretends to work now: 

sage: P2 = toric_varieties.P2()
sage: P2a = P2.base_extend(FractionField(QQ["a"]))
sage: P2a.inject_coefficients()
Defining a
sage: a
...
NameError: name 'a' is not defined

Depends on #10355.

Attachments (1)

trac_10498_fix_inject_coefficients.patch​ (2.8 KB) - added by novoselt 10 years ago.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by novoselt

comment:1 Changed 10 years ago by novoselt

  • Cc vbraun added
  • Status changed from new to needs_review

Depends on #10355.

comment:2 Changed 10 years ago by vbraun

  • Status changed from needs_review to positive_review

Nice! Tested on 4.6.1alpha3.

comment:3 Changed 10 years ago by vbraun

  • Reviewers set to Volker Braun

comment:4 Changed 10 years ago by jdemeyer

I get a failure in a doctest added by this patch: 

sage -t  -force_lib devel/sage/sage/schemes/generic/toric_variety.py
**********************************************************************
File "/mnt/usb1/scratch/jdemeyer/merger/sage-4.6.2.alpha2/devel/sage-main/sage/schemes/generic/toric_variety.py", line 1054:
    sage: a + b in P1xP1.coordinate_ring()
Expected:
    True
Got:
    False
**********************************************************************

comment:5 Changed 10 years ago by jdemeyer

  • Status changed from positive_review to needs_work

comment:6 Changed 10 years ago by vbraun

  • Description modified (diff)
  • Status changed from needs_work to positive_review

I'm pretty sure you missed the dependency in comment:1. It works for me.

comment:7 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.6.2.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.