Opened 12 years ago
Closed 12 years ago
#10498 closed defect (fixed)
fix inject_coefficients for toric varieties
Reported by: | novoselt | Owned by: | AlexGhitza |
---|---|---|---|
Priority: | major | Milestone: | sage-4.6.2 |
Component: | algebraic geometry | Keywords: | |
Cc: | vbraun | Merged in: | sage-4.6.2.alpha2 |
Authors: | Andrey Novoseltsev | Reviewers: | Volker Braun |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Because it only pretends to work now:
sage: P2 = toric_varieties.P2() sage: P2a = P2.base_extend(FractionField(QQ["a"])) sage: P2a.inject_coefficients() Defining a sage: a ... NameError: name 'a' is not defined
Depends on #10355.
Attachments (1)
Change History (8)
Changed 12 years ago by
Attachment: | trac_10498_fix_inject_coefficients.patch added |
---|
comment:1 Changed 12 years ago by
Cc: | vbraun added |
---|---|
Status: | new → needs_review |
comment:2 Changed 12 years ago by
Status: | needs_review → positive_review |
---|
Nice! Tested on 4.6.1alpha3.
comment:3 Changed 12 years ago by
Reviewers: | → Volker Braun |
---|
comment:4 Changed 12 years ago by
I get a failure in a doctest added by this patch:
sage -t -force_lib devel/sage/sage/schemes/generic/toric_variety.py ********************************************************************** File "/mnt/usb1/scratch/jdemeyer/merger/sage-4.6.2.alpha2/devel/sage-main/sage/schemes/generic/toric_variety.py", line 1054: sage: a + b in P1xP1.coordinate_ring() Expected: True Got: False **********************************************************************
comment:5 Changed 12 years ago by
Status: | positive_review → needs_work |
---|
comment:6 Changed 12 years ago by
Description: | modified (diff) |
---|---|
Status: | needs_work → positive_review |
I'm pretty sure you missed the dependency in comment:1. It works for me.
comment:7 Changed 12 years ago by
Merged in: | → sage-4.6.2.alpha2 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Depends on #10355.