Compute the matrices of diamond bracket operators

[davidloeffler]

It would be nice to be able to compute the matrices of the diamond bracket operators <d> on spaces of Gamma1 (and GammaH) modular forms. At present this doesn't seem to be implemented.

(Note that this subsumes #10438, which can be closed as duplicate.)

Apply trac-10451-diamond_operators-review.patch​

[davidloeffler]

patch against 4.6.1.alpha3 + #8716

[davidloeffler]

Here's a patch. It requires #8716, but is independent of any of my other recent modular forms patches.

[davidloeffler]

Depends on #8716
Apply trac_10451-diamond_operators.patch

(FAO PatchBot)

[davidloeffler]

Depends on #8716

(Why isn't Patchbot picking this up?)

[mraum]

I browsed through the code and the implementation looks good. I still need to think more thoroughly about whether there are any sever consequences when making the diamond operators an element of the Hecke algebra in Sage.

One question: Are there particular reasons why you call the first function in your code diamond_bracket_matrix and not diamond_bracket_operator? After all it's still an element of the Hecke algebra and it has a method .matrix(). In my opinion this might cause confusion.

Martin

[davidloeffler]

Hi Martin,

Thanks for looking at this!

Can you tell me more precisely which function your last comment refers to? I wanted to stick to the convention that functions with "matrix" in the name returned a matrix, and things with "operator" return an element of a Hecke algebra. I can't see anywhere in the patch where this is violated -- can you show me where?

David

[mraum]

There has been a tiny change to 4.6.2 and I adapted the rewrite of free_module. Apart from this I slightly adjusted the documentation. All tests pass. If you are OK with the review patch, you can give it a positive review.

For the patchbot and the release manager: Apply trac_10451-diamond_operators-review.patch

[davidloeffler]

I'm happy with the changes. Thanks for cleaning up my docstrings!

Apply trac-10451-diamond_operators-review.patch

[jdemeyer]

Replying to mraum:

For the patchbot and the release manager:

Apply trac_10451-diamond_operators-review.patch

Please put this information in the ticket description next time.

[jdemeyer]

You even misspelled the attachment name so it's useless for the patchbot!