Opened 9 years ago
Closed 8 years ago
#10451 closed enhancement (fixed)
Compute the matrices of diamond bracket operators
Reported by: | davidloeffler | Owned by: | craigcitro |
---|---|---|---|
Priority: | major | Milestone: | sage-4.7 |
Component: | modular forms | Keywords: | |
Cc: | mraum@… | Merged in: | sage-4.7.alpha3 |
Authors: | David Loeffler | Reviewers: | Martin Raum |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
It would be nice to be able to compute the matrices of the diamond bracket operators <d> on spaces of Gamma1 (and GammaH) modular forms. At present this doesn't seem to be implemented.
(Note that this subsumes #10438, which can be closed as duplicate.)
Attachments (2)
Change History (14)
Changed 9 years ago by
comment:1 Changed 9 years ago by
- Status changed from new to needs_review
Here's a patch. It requires #8716, but is independent of any of my other recent modular forms patches.
comment:2 Changed 8 years ago by
- Description modified (diff)
comment:3 Changed 8 years ago by
Depends on #8716 Apply trac_10451-diamond_operators.patch (FAO PatchBot)
comment:4 Changed 8 years ago by
Depends on #8716
(Why isn't Patchbot picking this up?)
comment:5 Changed 8 years ago by
- Priority changed from minor to major
comment:6 Changed 8 years ago by
- Cc mraum@… added
I browsed through the code and the implementation looks good. I still need to think more thoroughly about whether there are any sever consequences when making the diamond operators an element of the Hecke algebra in Sage.
One question: Are there particular reasons why you call the first function in your code diamond_bracket_matrix and not diamond_bracket_operator? After all it's still an element of the Hecke algebra and it has a method .matrix(). In my opinion this might cause confusion.
Martin
comment:7 Changed 8 years ago by
Hi Martin,
Thanks for looking at this!
Can you tell me more precisely which function your last comment refers to? I wanted to stick to the convention that functions with "matrix" in the name returned a matrix, and things with "operator" return an element of a Hecke algebra. I can't see anywhere in the patch where this is violated -- can you show me where?
David
comment:8 follow-up: ↓ 10 Changed 8 years ago by
There has been a tiny change to 4.6.2 and I adapted the rewrite of free_module. Apart from this I slightly adjusted the documentation. All tests pass. If you are OK with the review patch, you can give it a positive review.
For the patchbot and the release manager: Apply trac_10451-diamond_operators-review.patch
Changed 8 years ago by
comment:9 Changed 8 years ago by
- Reviewers set to Martin Raum
- Status changed from needs_review to positive_review
I'm happy with the changes. Thanks for cleaning up my docstrings!
Apply trac-10451-diamond_operators-review.patch
comment:10 in reply to: ↑ 8 Changed 8 years ago by
- Description modified (diff)
Replying to mraum:
For the patchbot and the release manager:
Apply trac_10451-diamond_operators-review.patch
Please put this information in the ticket description next time.
comment:11 Changed 8 years ago by
- Description modified (diff)
You even misspelled the attachment name so it's useless for the patchbot!
comment:12 Changed 8 years ago by
- Merged in set to sage-4.7.alpha3
- Resolution set to fixed
- Status changed from positive_review to closed
patch against 4.6.1.alpha3 + #8716