Sage: Ticket #10434: add doctests from #8582 and other integration improvements from Maxima 5.22.1
https://trac.sagemath.org/ticket/10434
<p>
This is a follow-up to ticket <a class="closed ticket" href="https://trac.sagemath.org/ticket/10187" title="defect: Update ECL to 10.4.1 and Maxima to 5.22.1 - currently the latest releases. (closed: fixed)">#10187</a>. Tickets <a class="closed ticket" href="https://trac.sagemath.org/ticket/8582" title="defect: sum(1/(1+k^2), k, -oo, oo) returns 0 (closed: fixed)">#8582</a> and <a class="closed ticket" href="https://trac.sagemath.org/ticket/8624" title="defect: integral of abs(cos(x))*sin(x) gives false results (closed: fixed)">#8624</a> have many useful doctests to ensure that the upgrade to Maxima 5.22.1 fixes many reported issues. Add those doctests.
</p>
en-usSagehttps://trac.sagemath.org/chrome/site/logo_sagemath_trac.png
https://trac.sagemath.org/ticket/10434
Trac 1.1.6mvnguMon, 06 Dec 2010 13:38:16 GMTdescription changed
https://trac.sagemath.org/ticket/10434#comment:1
https://trac.sagemath.org/ticket/10434#comment:1
<ul>
<li><strong>description</strong>
modified (<a href="/ticket/10434?action=diff&version=1">diff</a>)
</li>
</ul>
TicketburcinMon, 06 Dec 2010 14:01:42 GMTcc set
https://trac.sagemath.org/ticket/10434#comment:2
https://trac.sagemath.org/ticket/10434#comment:2
<ul>
<li><strong>cc</strong>
<em>burcin</em> added
</li>
</ul>
TicketmvnguMon, 06 Dec 2010 15:30:17 GMTattachment set
https://trac.sagemath.org/ticket/10434
https://trac.sagemath.org/ticket/10434
<ul>
<li><strong>attachment</strong>
set to <em>trac-10434_doctests.patch</em>
</li>
</ul>
TicketmvnguMon, 06 Dec 2010 15:31:18 GMTstatus changed; author set
https://trac.sagemath.org/ticket/10434#comment:3
https://trac.sagemath.org/ticket/10434#comment:3
<ul>
<li><strong>status</strong>
changed from <em>new</em> to <em>needs_review</em>
</li>
<li><strong>author</strong>
set to <em>Minh Van Nguyen</em>
</li>
</ul>
<p>
In Sage 4.6.1.alpha3, I cannot/don't know how to reproduce the following:
</p>
<pre class="wiki">sage: integrate(sqrt(x + sqrt(x)), x).simplify_full()
1/12*sqrt(sqrt(x) + 1)*((8*x - 3)*x^(1/4) + 2*x^(3/4)) - 1/8*log(sqrt(sqrt(x) + 1) - x^(1/4)) + 1/8*log(sqrt(sqrt(x) + 1) + x^(1/4))
</pre><p>
I left out the remaining doctests from <a class="missing attachment">http://trac.sagemath.org/sage_trac/raw-attachment/ticket/8624/trac-8624-abs-integration.patch</a> because those, I think, haven't resulted in failures.
</p>
TicketkcrismanMon, 06 Dec 2010 18:46:52 GMT
https://trac.sagemath.org/ticket/10434#comment:4
https://trac.sagemath.org/ticket/10434#comment:4
<p>
I really hate opening new tickets... makes it look like we're making Sage better than is actually true. Anyway, once I get the chance to upgrade I will take a look at this.
</p>
TicketburcinMon, 06 Dec 2010 19:03:49 GMTcc changed
https://trac.sagemath.org/ticket/10434#comment:5
https://trac.sagemath.org/ticket/10434#comment:5
<ul>
<li><strong>cc</strong>
<em>jason</em> added
</li>
</ul>
<p>
Replying to <a class="ticket" href="https://trac.sagemath.org/ticket/10434#comment:4" title="Comment 4">kcrisman</a>:
</p>
<blockquote class="citation">
<p>
I really hate opening new tickets... makes it look like we're making Sage better than is actually true. Anyway, once I get the chance to upgrade I will take a look at this.
</p>
</blockquote>
<p>
I agree. I would have preferred to close those tickets after merging patches with doctests as well.
</p>
<p>
In this case, I think we should still reopen <a class="closed ticket" href="https://trac.sagemath.org/ticket/8624" title="defect: integral of abs(cos(x))*sin(x) gives false results (closed: fixed)">#8624</a> and change the summary to "enable abs_integrate package from maxima".
</p>
TicketkcrismanWed, 08 Dec 2010 21:08:14 GMTstatus, summary changed; reviewer set
https://trac.sagemath.org/ticket/10434#comment:6
https://trac.sagemath.org/ticket/10434#comment:6
<ul>
<li><strong>status</strong>
changed from <em>needs_review</em> to <em>positive_review</em>
</li>
<li><strong>reviewer</strong>
set to <em>Karl-Dieter Crisman</em>
</li>
<li><strong>summary</strong>
changed from <em>add doctests from #8624 and #8582</em> to <em>add doctests from #8582 and other integration improvements from Maxima 5.22.1</em>
</li>
</ul>
<p>
Okay, correctly checks <a class="closed ticket" href="https://trac.sagemath.org/ticket/8582" title="defect: sum(1/(1+k^2), k, -oo, oo) returns 0 (closed: fixed)">#8582</a> and does the right stuff from <a class="closed ticket" href="https://trac.sagemath.org/ticket/8624" title="defect: integral of abs(cos(x))*sin(x) gives false results (closed: fixed)">#8624</a> that we need. I agree with Minh that the other stuff was not needed.
</p>
<p>
Very odd about the <code>sqrt(x+sqrt(x))</code> thing. I think that Burcin is right; we never enabled the abs integrate - Maxima just got better at the <a class="closed ticket" href="https://trac.sagemath.org/ticket/8624" title="defect: integral of abs(cos(x))*sin(x) gives false results (closed: fixed)">#8624</a> integrals on its own:
</p>
<pre class="wiki">
Maxima 5.22.1 http://maxima.sourceforge.net
using Lisp ECL 10.4.1
Distributed under the GNU Public License. See the file COPYING.
Dedicated to the memory of William Schelter.
The function bug_report() provides bug reporting information.
(%i1) integrate(abs(cos(x))*sin(x),x,%pi/2,%pi);
1
(%o1) -
2
</pre><p>
So I respectfully request that someone with the authority reopen that ticket as he suggests, with new title. Using <code>abs_integrate</code> does solve the square root integral in question (<code>sqrt(x+sqrt(x))</code>).
</p>
<p>
However, I think that this one can still be merged, since there are no problems with these, and they were verified as correct on the relevant tickets, and it passes the tests, of course, and applies, of course.
</p>
<p>
To release manager/patchbot: doc fix only, apply trac-10434_doctests.patch
</p>
TicketjdemeyerSun, 19 Dec 2010 09:34:02 GMTstatus changed; resolution, merged set
https://trac.sagemath.org/ticket/10434#comment:7
https://trac.sagemath.org/ticket/10434#comment:7
<ul>
<li><strong>status</strong>
changed from <em>positive_review</em> to <em>closed</em>
</li>
<li><strong>resolution</strong>
set to <em>fixed</em>
</li>
<li><strong>merged</strong>
set to <em>sage-4.6.1.rc0</em>
</li>
</ul>
TicketkcrismanTue, 14 Jun 2011 18:15:07 GMT
https://trac.sagemath.org/ticket/10434#comment:8
https://trac.sagemath.org/ticket/10434#comment:8
<p>
See also <a class="closed ticket" href="https://trac.sagemath.org/ticket/11483" title="enhancement: enable abs_integrate package from maxima (closed: fixed)">#11483</a> for the <code>abs_integrate</code> stuff.
</p>
Ticket