Changes between Version 14 and Version 19 of Ticket #10334


Ignore:
Timestamp:
May 3, 2011, 1:09:17 PM (12 years ago)
Author:
Rob Beezer
Comment:

On 4.7.rc0.

1) 3 hunk failures when applying trac_10334-permgroup_cleanup-rebase-mh.patch, a rebase is attached.

2) With rebase a quotient group fails in a doctest. Here's the evidence:

Clean 4.7.rc0:

G = DihedralGroup(20)
C = G.commutator()
Q = G.quotient(C)
Q.is_abelian()

4.7.rc0 with rebased patch:

sage: G = DihedralGroup(20)
sage: C = G.commutator()
sage: Q = G.quotient(C)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)

/home/sage/sage-4.7.rc0/devel/sage-main/<ipython console> in <module>()

/sage/sage-4.7.rc0/local/lib/python2.6/site-packages/sage/groups/perm_gps/permgroup.pyc in quotient(self, N)
   1483         phi = Q.RegularActionHomomorphism()
   1484         gens = phi.Image().GeneratorsOfGroup()
-> 1485         return PermutationGroup([self(gen) for gen in gens])
   1486
   1487     def quotient_group(self, N):

/sage/sage-4.7.rc0/local/lib/python2.6/site-packages/sage/groups/perm_gps/permgroup.pyc in __call__(self, x, check)
    593             return self.identity()
    594
--> 595         return self._element_class()(x, self, check=check)
    596
    597     def _coerce_impl(self, x):

/sage/sage-4.7.rc0/local/lib/python2.6/site-packages/sage/groups/perm_gps/permgroup_element.so in sage.groups.perm_gps.permgroup_element.PermutationGroupElement.__init__ (sage/groups/perm_gps/permgroup_element.c:3008)()

TypeError: permutation (1, 2)(3, 4) not in Dihedral group of order 40 as a permutation group

I've tried to locate the error, with no luck. My rebase could be at fault, but I've double-checked that as well.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10334

    • Property Status changed from positive_review to needs_work
    • Property Priority changed from major to minor
    • Property Milestone changed from sage-4.6.2 to sage-4.7
    • Property Resolution changed from fixed to
  • Ticket #10334 – Description

    v14 v19  
    11'''Apply''':
    2  1. [attachment:trac_10334-permgroup_cleanup-mh.patch]
     2 1. [attachment:trac_10334-permgroup_cleanup-rebase-mh.patch]