Opened 10 years ago

Closed 10 years ago

#10329 closed enhancement (fixed)

add Goldner-Harary graph to common graphs database

Reported by: mvngu Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-4.6.2
Component: graph theory Keywords:
Cc: Merged in: sage-4.6.2.alpha0
Authors: Minh Van Nguyen Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mvngu)

As the subject says. This is part of the larger project at #9136.

Prerequisite: #10322

Apply:

  1. trac-10329_goldner-harary.patch
  2. trac_10329-positions.patch

Attachments (2)

trac-10329_goldner-harary.patch (2.6 KB) - added by mvngu 10 years ago.
trac_10329-positions.patch (1.0 KB) - added by ncohen 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by mvngu

comment:1 Changed 10 years ago by mvngu

  • Authors set to Minh Van Nguyen
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 follow-up: Changed 10 years ago by ncohen

I wasn't able to find an embedding which would be both pleasant to the eye and which wouldn't hide an edge... Well, I think this is still better than having no embedding ^^;

If you can review my small patch, the whole ticket is good to go :-)

Nathann

Changed 10 years ago by ncohen

comment:3 in reply to: ↑ 2 Changed 10 years ago by mvngu

  • Description modified (diff)
  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

Replying to ncohen:

If you can review my small patch, the whole ticket is good to go :-)

Your embedding looks better than what I was able to do. Positive review.

comment:4 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.6.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.