Opened 12 years ago

Closed 12 years ago

#10318 closed defect (fixed)

Change CompositConstructionFunctor to CompositeConstructionFunctor

Reported by: John Cremona Owned by: Nicolas M. Thiéry
Priority: trivial Milestone: sage-4.6.2
Component: categories Keywords:
Cc: Merged in: sage-4.6.2.alpha0
Authors: John Cremona Reviewers: David Kirkby
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Attachments (1)

trac_10318-Composit.patch (11.3 KB) - added by John Cremona 12 years ago.
Applies to 4.6.1.alpha2 + patch from #8807

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by John Cremona

Attachment: trac_10318-Composit.patch added

Applies to 4.6.1.alpha2 + patch from #8807

comment:1 Changed 12 years ago by John Cremona

Status: newneeds_review

comment:2 Changed 12 years ago by David Kirkby

Reviewers: David Kirkby

I'm a bit puzzled why the need for two patches. Is the combined patch one in which could be used instead of the patch on #8807?

I have no problems giving the small patch a positive reivew. I guess its up to the release manager how best to handle this - whether #8807 is applied first, and then your simple patch, or just your combined patch.

I would have thought the best way to handle this was to just have the simple patch, and make it conditional on #8807 being applied first.

Dave

comment:3 Changed 12 years ago by David Kirkby

Status: needs_reviewpositive_review

Ignore what I said - I see this patch just does many identical spelling corrections - I assumed initially it was just one spelling correction, along with the whole contents of another patch, which made less sence

comment:4 Changed 12 years ago by John Cremona

That's right -- I made it conditional on the #8807 patch since that patch has the word in it, and it also makes a lot of changes to the file where most of the occurrences occur.

I'll put a cross-reference at #8807 saying that this ticket has a positive review and can/should be merged right after that one.

comment:5 Changed 12 years ago by Jeroen Demeyer

Milestone: sage-4.6.1sage-4.6.2

comment:6 Changed 12 years ago by Simon King

depends on #8807

comment:7 Changed 12 years ago by Jeroen Demeyer

Merged in: sage-4.6.2.alpha0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.