Opened 10 years ago
Closed 10 years ago
#10318 closed defect (fixed)
Change CompositConstructionFunctor to CompositeConstructionFunctor
Reported by: | cremona | Owned by: | nthiery |
---|---|---|---|
Priority: | trivial | Milestone: | sage-4.6.2 |
Component: | categories | Keywords: | |
Cc: | Merged in: | sage-4.6.2.alpha0 | |
Authors: | John Cremona | Reviewers: | David Kirkby |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
I think that CompositConstructionFunctor? should be CompositeConstructionFunctor?.
Attachments (1)
Change History (8)
Changed 10 years ago by
comment:1 Changed 10 years ago by
- Status changed from new to needs_review
comment:2 Changed 10 years ago by
- Reviewers set to David Kirkby
I'm a bit puzzled why the need for two patches. Is the combined patch one in which could be used instead of the patch on #8807?
I have no problems giving the small patch a positive reivew. I guess its up to the release manager how best to handle this - whether #8807 is applied first, and then your simple patch, or just your combined patch.
I would have thought the best way to handle this was to just have the simple patch, and make it conditional on #8807 being applied first.
Dave
comment:3 Changed 10 years ago by
- Status changed from needs_review to positive_review
Ignore what I said - I see this patch just does many identical spelling corrections - I assumed initially it was just one spelling correction, along with the whole contents of another patch, which made less sence
comment:4 Changed 10 years ago by
That's right -- I made it conditional on the #8807 patch since that patch has the word in it, and it also makes a lot of changes to the file where most of the occurrences occur.
I'll put a cross-reference at #8807 saying that this ticket has a positive review and can/should be merged right after that one.
comment:5 Changed 10 years ago by
- Milestone changed from sage-4.6.1 to sage-4.6.2
comment:6 Changed 10 years ago by
depends on #8807
comment:7 Changed 10 years ago by
- Merged in set to sage-4.6.2.alpha0
- Resolution set to fixed
- Status changed from positive_review to closed
Applies to 4.6.1.alpha2 + patch from #8807