Opened 9 years ago

Closed 9 years ago

#10310 closed enhancement (fixed)

add Brinkmann graph to common graph database

Reported by: mvngu Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-4.6.2
Component: graph theory Keywords:
Cc: Merged in: sage-4.6.2.alpha0
Authors: Minh Van Nguyen Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by mvngu)

As the subject says. This is part of the larger project at #9136.

Prerequisite: #10307

Apply:

  1. #10307
  2. trac-10310_brinkmann-graph.patch
  3. trac_10310-smallfix.2.patch

Attachments (3)

trac-10310_brinkmann-graph.patch (3.8 KB) - added by mvngu 9 years ago.
trac_10310-smallfix.patch (1.3 KB) - added by ncohen 9 years ago.
trac_10310-smallfix.2.patch (1.3 KB) - added by mvngu 9 years ago.

Download all attachments as: .zip

Change History (12)

Changed 9 years ago by mvngu

comment:1 Changed 9 years ago by mvngu

  • Authors set to Minh Van Nguyen
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 follow-up: Changed 9 years ago by ncohen

Hello Minh !!!!

Nice patch !! I added a small one about this is_regular method again, and also a small docstring checking the automorphism group (thanks to wikipedia) while I was at it :-)

Nathann

Changed 9 years ago by ncohen

comment:3 Changed 9 years ago by ncohen

  • Reviewers set to Nathann Cohen

comment:4 Changed 9 years ago by jdemeyer

  • Milestone changed from sage-4.6.1 to sage-4.6.2

comment:5 in reply to: ↑ 2 Changed 9 years ago by mvngu

  • Status changed from needs_review to positive_review

Replying to ncohen:

I added a small one about this is_regular method again, and also a small docstring checking the automorphism group (thanks to wikipedia) while I was at it :-)

Thank you. Positive review.

comment:6 Changed 9 years ago by jdemeyer

  • Status changed from positive_review to needs_work

The commit message of the second patch should not be one long line. Provide a short description on the first line (this will appear in hg log). Any further info should go on following lines.

Changed 9 years ago by mvngu

comment:7 Changed 9 years ago by mvngu

  • Description modified (diff)
  • Status changed from needs_work to needs_review

comment:8 Changed 9 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:9 Changed 9 years ago by jdemeyer

  • Merged in set to sage-4.6.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.