Opened 12 years ago

Closed 12 years ago

#10310 closed enhancement (fixed)

add Brinkmann graph to common graph database

Reported by: Minh Van Nguyen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-4.6.2
Component: graph theory Keywords:
Cc: Merged in: sage-4.6.2.alpha0
Authors: Minh Van Nguyen Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Minh Van Nguyen)

As the subject says. This is part of the larger project at #9136.

Prerequisite: #10307

Apply:

  1. #10307
  2. trac-10310_brinkmann-graph.patch
  3. trac_10310-smallfix.2.patch

Attachments (3)

trac-10310_brinkmann-graph.patch (3.8 KB) - added by Minh Van Nguyen 12 years ago.
trac_10310-smallfix.patch (1.3 KB) - added by Nathann Cohen 12 years ago.
trac_10310-smallfix.2.patch (1.3 KB) - added by Minh Van Nguyen 12 years ago.

Download all attachments as: .zip

Change History (12)

Changed 12 years ago by Minh Van Nguyen

comment:1 Changed 12 years ago by Minh Van Nguyen

Authors: Minh Van Nguyen
Description: modified (diff)
Status: newneeds_review

comment:2 Changed 12 years ago by Nathann Cohen

Hello Minh !!!!

Nice patch !! I added a small one about this is_regular method again, and also a small docstring checking the automorphism group (thanks to wikipedia) while I was at it :-)

Nathann

Changed 12 years ago by Nathann Cohen

Attachment: trac_10310-smallfix.patch added

comment:3 Changed 12 years ago by Nathann Cohen

Reviewers: Nathann Cohen

comment:4 Changed 12 years ago by Jeroen Demeyer

Milestone: sage-4.6.1sage-4.6.2

comment:5 in reply to:  2 Changed 12 years ago by Minh Van Nguyen

Status: needs_reviewpositive_review

Replying to ncohen:

I added a small one about this is_regular method again, and also a small docstring checking the automorphism group (thanks to wikipedia) while I was at it :-)

Thank you. Positive review.

comment:6 Changed 12 years ago by Jeroen Demeyer

Status: positive_reviewneeds_work

The commit message of the second patch should not be one long line. Provide a short description on the first line (this will appear in hg log). Any further info should go on following lines.

Changed 12 years ago by Minh Van Nguyen

Attachment: trac_10310-smallfix.2.patch added

comment:7 Changed 12 years ago by Minh Van Nguyen

Description: modified (diff)
Status: needs_workneeds_review

comment:8 Changed 12 years ago by Jeroen Demeyer

Status: needs_reviewpositive_review

comment:9 Changed 12 years ago by Jeroen Demeyer

Merged in: sage-4.6.2.alpha0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.