Opened 12 years ago

Closed 12 years ago

#10307 closed enhancement (fixed)

add Bidiakis cube graph to common graph database

Reported by: mvngu Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-4.6.2
Component: graph theory Keywords:
Cc: Merged in: sage-4.6.2.alpha0
Authors: Minh Van Nguyen Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

As the subject says. This is part of the larger project at #9136.

Attachments (2)

trac-10307_bidiakis-cube.patch (3.0 KB) - added by mvngu 12 years ago.
trac_10307-smallfix.patch (861 bytes) - added by ncohen 12 years ago.

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by mvngu

comment:1 Changed 12 years ago by mvngu

Authors: Minh Van Nguyen
Status: newneeds_review

comment:2 Changed 12 years ago by ncohen

Reviewers: Nathann Cohen

Hello Minh !!!!

I didn't expect to find anything wrong with the doc, or with the doctests in your patch... And there wasn't ! :-D

I just spotted you were redefining the "is 3-regular" method, which Sage already knows. So here is a one-line patch to add to yours. Afterwards, this ticket is good to go !

Nathann

Changed 12 years ago by ncohen

Attachment: trac_10307-smallfix.patch added

comment:3 in reply to:  2 Changed 12 years ago by mvngu

Status: needs_reviewpositive_review

Replying to ncohen:

I just spotted you were redefining the "is 3-regular" method, which Sage already knows. So here is a one-line patch to add to yours. Afterwards, this ticket is good to go !

Thank you. Positive review.

comment:4 Changed 12 years ago by jdemeyer

Milestone: sage-4.6.1sage-4.6.2

comment:5 Changed 12 years ago by jdemeyer

Merged in: sage-4.6.2.alpha0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.