Opened 12 years ago
Closed 12 years ago
#10307 closed enhancement (fixed)
add Bidiakis cube graph to common graph database
| Reported by: | mvngu | Owned by: | jason, ncohen, rlm |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.6.2 |
| Component: | graph theory | Keywords: | |
| Cc: | Merged in: | sage-4.6.2.alpha0 | |
| Authors: | Minh Van Nguyen | Reviewers: | Nathann Cohen |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Status badges
Description
As the subject says. This is part of the larger project at #9136.
Attachments (2)
Change History (7)
Changed 12 years ago by
| Attachment: | trac-10307_bidiakis-cube.patch added |
|---|
comment:1 Changed 12 years ago by
| Authors: | → Minh Van Nguyen |
|---|---|
| Status: | new → needs_review |
comment:2 follow-up: 3 Changed 12 years ago by
| Reviewers: | → Nathann Cohen |
|---|
Changed 12 years ago by
| Attachment: | trac_10307-smallfix.patch added |
|---|
comment:3 Changed 12 years ago by
| Status: | needs_review → positive_review |
|---|
Replying to ncohen:
I just spotted you were redefining the "is 3-regular" method, which Sage already knows. So here is a one-line patch to add to yours. Afterwards, this ticket is good to go !
Thank you. Positive review.
comment:4 Changed 12 years ago by
| Milestone: | sage-4.6.1 → sage-4.6.2 |
|---|
comment:5 Changed 12 years ago by
| Merged in: | → sage-4.6.2.alpha0 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Hello Minh !!!!
I didn't expect to find anything wrong with the doc, or with the doctests in your patch... And there wasn't !
:-DI just spotted you were redefining the "is 3-regular" method, which Sage already knows. So here is a one-line patch to add to yours. Afterwards, this ticket is good to go !
Nathann