Opened 11 years ago

Closed 11 years ago

#10270 closed defect (fixed)

proof.polynomial(False) has no effect on factor

Reported by: zimmerma Owned by: malb
Priority: minor Milestone: sage-4.6.1
Component: commutative algebra Keywords:
Cc: mmezzarobba, cremona Merged in: sage-4.6.1.alpha2
Authors: André Apitzsch Reviewers: Paul Zimmermann
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

the documentation of proof.polynomial says:

If t == False, allows polynomial algorithms to (by
default) return results that may depend on unproven conjectures
or on probabilistic algorithms.

However this does not work with the factor function:

sage: proof.polynomial(False)
sage: R.<x,y,z> = GF(3)[]
sage: (x^2*z^2+x*y*z-y^2).factor()
---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)

Attachments (1)

10270_proofpolynomial.patch (2.2 KB) - added by aapitzsch 11 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 11 years ago by aapitzsch

  • Status changed from new to needs_review

comment:2 Changed 11 years ago by aapitzsch

  • Authors set to André Apitzsch

comment:3 Changed 11 years ago by zimmerma

  • Reviewers set to Paul Zimmermann
  • Status changed from needs_review to needs_work

great! All tests pass. A minor request before giving a positive review: is it possible to add a test checking that the factorization works with proof=False, and fails with proof=True?

Paul

Changed 11 years ago by aapitzsch

comment:4 Changed 11 years ago by aapitzsch

  • Status changed from needs_work to needs_review

comment:5 Changed 11 years ago by zimmerma

  • Status changed from needs_review to positive_review

thank you for the added example!

Paul

comment:6 Changed 11 years ago by jdemeyer

  • Merged in set to sage-4.6.1.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.