Opened 11 years ago

Closed 9 years ago

Last modified 9 years ago

#10259 closed defect (worksforme)

success error code returned when spkg install fails

Reported by: robertwb Owned by: GeorgSWeber
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: build Keywords:
Cc: Merged in:
Authors: Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by robertwb)

For example, try out the (failing) attached spkg whose spkg-install is just "exit 1"

Attachments (1)

bad.spkg (178 bytes) - added by robertwb 11 years ago.
Spkg failing to install.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 11 years ago by robertwb

  • Description modified (diff)

Changed 11 years ago by robertwb

Spkg failing to install.

comment:2 Changed 9 years ago by kcrisman

  • Milestone set to sage-duplicate/invalid/wontfix
  • Reviewers set to Karl-Dieter Crisman
  • Status changed from new to needs_review
$ ./sage -i http://trac.sagemath.org/sage_trac/raw-attachment/ticket/10259/bad.spkg
Attempting to download package bad
>>> Downloading bad.spkg.
[.]
bad
====================================================
Extracting package /Users/karl.crisman/Downloads/sage-5.9.rc0/spkg/optional/bad.spkg
<snip>
Thread model: posix
gcc version 4.7.2 (GCC) 
****************************************************

real	0m0.001s
user	0m0.000s
sys	0m0.000s
************************************************************************
Error installing package bad
************************************************************************
Please email sage-devel (http://groups.google.com/group/sage-devel)
<snip>

This was on OS X. Same result on boxes.math. And if I write a script that checks the exit code

echo "Trying stuff"
./sage -i http://trac.sagemath.org/sage_trac/raw-attachment/ticket/10259/bad.spkg
if [ $? -ne 0 ]; then
    echo "it failed"
fi

works as expected. I believe we can close this, then?

comment:3 Changed 9 years ago by tscrim

  • Status changed from needs_review to positive_review

Worked for me on Ubuntu as well. I think this can be closed.

comment:4 Changed 9 years ago by jdemeyer

  • Resolution set to worksforme
  • Status changed from positive_review to closed

comment:5 Changed 9 years ago by SimonKing

See #14492: I still observe those wrong success reports. This is on an openSuse laptop,

> uname -a
Linux linux-sqwp.site 3.1.10-1.19-desktop #1 SMP PREEMPT Mon Feb 25 10:32:50 UTC 2013 (f0b13a3) x86_64 x86_64 x86_64 GNU/Linux
> cat /etc/issue
Welcome to openSUSE 12.1 "Asparagus" - Kernel \r (\l).

comment:6 follow-up: Changed 9 years ago by SimonKing

The spkg from here fails to install (as it should). But when I insert an unknown identifier into some Cython file in my group cohomology spkg, then sage-5.9.rc0 reports success, even though of course compilation fails.

So, shall one re-open this ticket?

comment:7 in reply to: ↑ 6 ; follow-up: Changed 9 years ago by jdemeyer

This ticket is about the general spkg/bin scripts. What you're observing in #14492 must be a problem with your particular package.

comment:8 in reply to: ↑ 7 Changed 9 years ago by SimonKing

Replying to jdemeyer:

This ticket is about the general spkg/bin scripts. What you're observing in #14492 must be a problem with your particular package.

Volker, for one, says that my spkg-install is fine. So, I'd rather assume that it is a problem with building Cython code in an spkg.

So, I'll try to create a new bad.spkg.

Note: See TracTickets for help on using tickets.