Opened 9 years ago
Closed 8 years ago
#10240 closed defect (duplicate)
pari-2.4.3.svn-12577.p9 incorrectly checks for the shared library on Cygwin
Reported by: | mhansen | Owned by: | tbd |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | packages: standard | Keywords: | |
Cc: | jdemeyer | Merged in: | |
Authors: | Dmitrii Pasechnik | Reviewers: | Karl-Dieter Crisman |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
In spkg-install, the following code should check for "libpari.dll" on Cygwin.
if [ "$UNAME" = "Darwin" ]; then pari_shlib="libpari.dylib" else pari_shlib="libpari.so" fi
The (trivial) fix is here: http://boxen.math.washington.edu/home/dima/packages/pari-2.4.3.alpha.p6.spkg
Change History (12)
comment:1 follow-up: ↓ 3 Changed 8 years ago by
comment:2 Changed 8 years ago by
- Description modified (diff)
- Status changed from new to needs_review
comment:3 in reply to: ↑ 1 ; follow-up: ↓ 5 Changed 8 years ago by
comment:4 Changed 8 years ago by
comment:5 in reply to: ↑ 3 Changed 8 years ago by
Replying to jdemeyer:
Replying to dimpase:
Should one work with the current pari spkg, i.e.pari-2.4.3.alpha.p5 ?
Yes. However, I am working on a new PARI spkg at #11130 (still needs work currently). I could merge this change into that new PARI spkg.
sure, please do --- it's just a couple of lines in the spkg-install
comment:6 Changed 8 years ago by
I put your changes into my new spkg http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.svn13151.p0.spkg but this ticket (i.e. your change) still needs to be reviewed by somebody using Cygwin.
comment:7 Changed 8 years ago by
- Reviewers set to Karl-Dieter Crisman
Dima's spkg worked on XP for me - PARI built. And the part of the spkg diff at #11130 looks correct.
Is that enough for a positive review?
comment:9 Changed 8 years ago by
- Milestone changed from sage-4.7.1 to sage-duplicate/invalid/wontfix
comment:10 follow-up: ↓ 11 Changed 8 years ago by
It would be really helpful to have this in Sage 4.7.2 fairly early on so that we could have building Sage on Cygwin automatically a goal for an early alpha of 4.7.2. Would it be okay to change the milestone to 4.7.2 if #11130 isn't going to be merged particularly soon?
comment:11 in reply to: ↑ 10 Changed 8 years ago by
Replying to kcrisman:
It would be really helpful to have this in Sage 4.7.2 fairly early on so that we could have building Sage on Cygwin automatically a goal for an early alpha of 4.7.2.
I've based a p7 spkg at #11605 (which hopefully gets into Sage 4.7.1 because it fixes a critical error in spkg-install
) on the p6 from here, i.e. it includes Dima's harmless changes.
If my spkg gets merged, this ticket can be closed as fixed.
comment:12 Changed 8 years ago by
- Resolution set to duplicate
- Status changed from positive_review to closed
Should one work with the current pari spkg, i.e.pari-2.4.3.alpha.p5 ?