Opened 12 years ago

Closed 7 years ago

#10232 closed defect (fixed)

check GLPK bound errors

Reported by: Martin Albrecht Owned by: jason, jkantor
Priority: major Milestone: sage-7.2
Component: numerical Keywords:
Cc: Matthias Köppe, Dima Pasechnik Merged in:
Authors: Vincent Delecroix Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 6503bc5 (Commits, GitHub, GitLab) Commit: 6503bc59718863887e5cc1a66c594be79912c071
Dependencies: #19525 Stopgaps:

Status badges

Description (last modified by Vincent Delecroix)

This should never happen: 

sage: from sage.numerical.backends.generic_backend import get_solver
sage: p = get_solver(solver = "GLPK") 
sage: p.add_variable()
1
sage: p.variable_upper_bound(1)
sig_error() without sig_on()
...
------------------------------------------------------------------------
Unhandled SIGABRT: An abort() occurred.
This probably occurred because a *compiled* module has a bug
in it and is not properly wrapped with sig_on(), sig_off().
Python will now terminate.
------------------------------------------------------------------------
Aborted

Change History (17)

comment:1 Changed 9 years ago by Jeroen Demeyer

Milestone: sage-5.11 → sage-5.12

comment:2 Changed 9 years ago by For batch modifications

Milestone: sage-6.1 → sage-6.2

comment:3 Changed 9 years ago by For batch modifications

Milestone: sage-6.2 → sage-6.3

comment:4 Changed 8 years ago by For batch modifications

Milestone: sage-6.3 → sage-6.4

comment:5 Changed 7 years ago by Vincent Delecroix

The method name changed 

AttributeError: 'sage.numerical.backends.glpk_backend.GLPKBackend' object has no attribute 'variable_max'

But still (with #19525 applied) 

sage: p.variable_upper_bound(1)
sig_error() without sig_on()
...
------------
Unhandled SIGABRT: An abort() occurred.
This probably occurred because a *compiled* module has a bug
in it and is not properly wrapped with sig_on(), sig_off().
Python will now terminate.
------------------------------------------------------------------------
Aborted

comment:6 Changed 7 years ago by Vincent Delecroix

Dependencies: → #19525
Description: modified (diff)
Milestone: sage-6.4 → sage-7.2

comment:7 Changed 7 years ago by Vincent Delecroix

Authors: → Vincent Delecroix
Branch: → u/vdelecroix/10232
Commit: → 6503bc59718863887e5cc1a66c594be79912c071
Status: new → needs_review

New commits:

​6503bc5Trac 10232: catch some errors in GLPK backend

comment:8 Changed 7 years ago by Vincent Delecroix

Cc: Matthias Köppe added; Nathann Cohen removed

comment:9 Changed 7 years ago by Matthias Köppe

Cc: Dima Pasechnik added

comment:10 Changed 7 years ago by Matthias Köppe

I think the title of this ticket needs to be changed to be more specific.

comment:11 Changed 7 years ago by Vincent Delecroix

Summary: MIP backends should perform bounds checks → check GLPK bound errors

comment:12 Changed 7 years ago by Dima Pasechnik

Summary: check GLPK bound errors → MIP backends should perform bounds checks

I've never seen <double?> syntax. What does it do?

comment:13 in reply to:  12 Changed 7 years ago by Vincent Delecroix

Replying to dimpase:

I've never seen <double?> syntax. What does it do?

It is a Cython cast with type checking: ​see the documentation.

comment:14 Changed 7 years ago by Dima Pasechnik

Status: needs_review → positive_review

OK

comment:15 Changed 7 years ago by Vincent Delecroix

Reviewers: → Dima Pasechnik

comment:16 Changed 7 years ago by Matthias Köppe

Summary: MIP backends should perform bounds checks → check GLPK bound errors

comment:17 Changed 7 years ago by Volker Braun

Branch: u/vdelecroix/10232 → 6503bc59718863887e5cc1a66c594be79912c071
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.