Opened 9 years ago
Closed 7 years ago
#10231 closed enhancement (invalid)
Don't repackage examples and extcode on sage-*dist
Reported by: | jdemeyer | Owned by: | tbd |
---|---|---|---|
Priority: | critical | Milestone: | sage-duplicate/invalid/wontfix |
Component: | distribution | Keywords: | scripts upgrade extcode examples sd32 |
Cc: | kini, leif | Merged in: | |
Authors: | Reviewers: | Jeroen Demeyer | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Right now, the version of the following packages is always bumped in every new Sage version:
sage sage_scripts extcode examples
This patch will remove the last two from this list and shift the problem of upgrading these packages to the release manager (i.e. the merger script).
Attachments (2)
Change History (17)
Changed 9 years ago by
comment:1 Changed 9 years ago by
- Summary changed from Don't rebuild examples and extcode on sage-*dist to Don't repackage examples and extcode on sage-*dist
comment:2 Changed 9 years ago by
- Description modified (diff)
comment:3 Changed 9 years ago by
- Status changed from new to needs_review
comment:4 Changed 9 years ago by
- Cc kini added
comment:5 Changed 9 years ago by
Well, I'm not sure how to test this, but the code changes look great to me. Hopefully someone who knows what they're saying can give this the go-ahead.
comment:6 Changed 9 years ago by
It would definitely be great to decouple these 2. Since this has been posted we have a new sage_root spkg should something be done here about it as well?
comment:7 Changed 9 years ago by
I have discussed this ticket a million times on sage-devel
and there never was a concensus about it, so I have essentially abandoned this effort. If however everybody suddenly thinks this ticket is a good idea, I'm willing to go ahead.
comment:8 Changed 9 years ago by
I was always in the "for" camp. Unsurprisingly because it is less work for me. I even suggest that the new version number of the spkg in question should be of the form {extcode,examples}-YYYYMMDD.
While there was no consensus on the list I suspect most people really don't care.
comment:9 follow-up: ↓ 10 Changed 8 years ago by
- Status changed from needs_review to needs_work
The patch 10231_scripts.patch fails to apply to sage-4.7.1.alpha2:
eno% ./sage ---------------------------------------------------------------------- | Sage Version 4.7.1.alpha2, Release Date: 2011-06-07 | | Type notebook() for the GUI, and license() for information. | ---------------------------------------------------------------------- ********************************************************************** * * * Warning: this is a prerelease version, and it may be unstable. * * * ********************************************************************** sage: hg_scripts.apply("/home/mariah/10231_scripts.patch") cd "/home/mariah/sage/sage-4.7.1.alpha2-x86_64-Linux-core2-fc/local/bin" && hg status cd "/home/mariah/sage/sage-4.7.1.alpha2-x86_64-Linux-core2-fc/local/bin" && hg status cd "/home/mariah/sage/sage-4.7.1.alpha2-x86_64-Linux-core2-fc/local/bin" && hg import "/home/mariah/10231_scripts.patch" applying /home/mariah/10231_scripts.patch patching file sage-make_devel_packages Hunk #2 FAILED at 18 Hunk #3 succeeded at 43 with fuzz 2 (offset 1 lines). Hunk #4 FAILED at 64 2 out of 4 hunks FAILED -- saving rejects to file sage-make_devel_packages.rej patching file sage-sdist Hunk #1 FAILED at 69 1 out of 1 hunks FAILED -- saving rejects to file sage-sdist.rej abort: patch failed to apply sage:
comment:10 in reply to: ↑ 9 Changed 8 years ago by
- Milestone changed from sage-4.7.1 to sage-wait
Replying to mariah:
The patch 10231_scripts.patch fails to apply to sage-4.7.1.alpha2
Could be. Since there is no consensus about whether this patch is a good idea, I am not going to work on this for now.
comment:11 Changed 8 years ago by
- Keywords sd32 added
comment:12 Changed 8 years ago by
- Cc leif added
- Work issues set to At least rebase...
comment:13 follow-up: ↓ 14 Changed 8 years ago by
At least we meanwhile got rid of the "examples" spkg / repo, so the resistance may have been halved by that, too. ;-)
I wouldn't delete extcode's spkg-dist
btw.; it doesn't hurt and can be used for testing / experimenting, or even still by a / the release manager.
comment:14 in reply to: ↑ 13 Changed 8 years ago by
Replying to leif:
At least we meanwhile got rid of the "examples" spkg / repo, so the resistance may have been halved by that, too. ;-)
I am very happy about that bit really.
I wouldn't delete extcode's
spkg-dist
btw.; it doesn't hurt and can be used for testing / experimenting, or even still by a / the release manager.
extcode has seen some activity in 4.7.1 and is set to get some activity in 4.7.3 but we should think about these sage specific spkg that are seldom updated.
We got rid of examples what else is low on updates?
comment:15 Changed 7 years ago by
- Milestone changed from sage-pending to sage-duplicate/invalid/wontfix
- Resolution set to invalid
- Reviewers set to Jeroen Demeyer
- Status changed from needs_work to closed
- Work issues At least rebase... deleted
Closing in the light of the move to GIT.
Remove spkg-dist from extcode (apply to extcode repo)