Opened 11 years ago

Closed 10 years ago

#10219 closed defect (fixed)

typo in rings/quotient_ring.py

Reported by: fwclarke Owned by: malb
Priority: minor Milestone: sage-4.6.1
Component: commutative algebra Keywords: quotient ring integral domain
Cc: spancratz Merged in: sage-4.6.1.alpha1
Authors: Francis Clarke Reviewers: Mike Hansen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The attached patch corrects a typo in sage.rings.quotient_ring.QuotientRing_generic.is_integral_domain (missing parentheses). In addition, the filtering of attribute errors has been removed. It is unnecessary because all ideals have the attribute is_prime. In the presence of the typo it gave misleading results:

sage: R.<x,y> = QQ[]
sage: R.quo(x^2 - y).is_integral_domain()
True
sage: R.quo(x^2 - y).is_integral_domain(proof=False)
False

The docstring has been rewritten to mention the proof keyword, and the doctests revised. 

Attachments (1)

trac_10219.patch (2.7 KB) - added by fwclarke 11 years ago.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by fwclarke

comment:1 Changed 11 years ago by fwclarke

  • Authors set to Francis Clarke
  • Cc spancratz added
  • Status changed from new to needs_review

comment:2 Changed 11 years ago by mhansen

  • Reviewers set to Mike Hansen
  • Status changed from needs_review to positive_review

Looks good to me.

comment:3 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.6.1.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.