Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#10211 closed defect (fixed)

flint/long_extras.pxd add missing parameters

Reported by: aapitzsch Owned by: William Stein
Priority: minor Milestone: sage-4.6.2
Component: number theory Keywords:
Cc: Merged in: sage-4.6.2.alpha0
Authors: André Apitzsch Reviewers: Sebastian Pancratz
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

According to FLINT/long_extras.h there are missing parameters in flint/long_extras.pxd

Attachments (1)

trac_10211_long_extras.patch (1.6 KB) - added by aapitzsch 12 years ago.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by aapitzsch

comment:1 Changed 12 years ago by aapitzsch

Status: newneeds_review

comment:2 Changed 12 years ago by spancratz

Status: needs_reviewpositive_review

Yes, this works. Thank you for picking this up!

By the way, if #5945 is merged, then this is definitely the right way to deal with this bad declarations. However, if #5945 is not merged, then the right approach here would be to simply delete the bad declarations since it seems they are not actually used anywhere in Sage.

Sebastian

comment:3 Changed 12 years ago by Jeroen Demeyer

Authors: André Apitzsch
Reviewers: Sebastian Pancratz

comment:4 Changed 12 years ago by Jeroen Demeyer

Merged in: sage-4.6.2.alpha0
Resolution: fixed
Status: positive_reviewclosed

comment:5 Changed 12 years ago by Minh Van Nguyen

Milestone: sage-4.6.2
Note: See TracTickets for help on using tickets.