Opened 12 years ago

Closed 12 years ago

#10210 closed defect (fixed)

Typos in sage/rings/arith.py

Reported by: jdemeyer Owned by: mvngu
Priority: trivial Milestone: sage-4.6.1
Component: documentation Keywords:
Cc: Merged in: sage-4.6.1.alpha1
Authors: Jeroen Demeyer Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description


Attachments (1)

10210_algdep_doc.patch (6.3 KB) - added by jdemeyer 12 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 12 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Status changed from new to needs_review

comment:2 Changed 12 years ago by leif

A height bound may be specified...

comment:3 Changed 12 years ago by leif

sufficiently small polynomial

comment:4 follow-up: Changed 12 years ago by leif

requires height_bound to be set

Shouldn't sqrt(2) be typeset in math mode?

(Though I generally hate that: For every "p" in p-adic an image is generated by TeX for the HTML documentation, which takes by far more than half of the docbuild time.)

comment:5 Changed 12 years ago by leif

  • Summary changed from Typo in sage/rings/arith.py to Typos in sage/rings/arith.py

comment:6 Changed 12 years ago by jdemeyer

Requested changes done

comment:7 follow-up: Changed 12 years ago by aapitzsch

  • Status changed from needs_review to needs_work

It should be default: (with colon)

Changed 12 years ago by jdemeyer

comment:8 in reply to: ↑ 7 Changed 12 years ago by jdemeyer

  • Status changed from needs_work to needs_review

Replying to aapitzsch:

It should be default: (with colon)

Done.

comment:9 Changed 12 years ago by aapitzsch

  • Reviewers set to André Apitzsch
  • Status changed from needs_review to positive_review

comment:10 in reply to: ↑ 4 ; follow-up: Changed 12 years ago by jsrn

Replying to leif:

requires height_bound to be set

Shouldn't sqrt(2) be typeset in math mode?

(Though I generally hate that: For every "p" in p-adic an image is generated by TeX for the HTML documentation, which takes by far more than half of the docbuild time.)

Surely Sphinx caches and reuses these bits and pieces of TeX-generated images. A small grep for some of the more often used images (like $A$) seemed to indicate that at least...

comment:11 in reply to: ↑ 10 Changed 12 years ago by leif

Replying to jsrn:

Replying to leif:

requires height_bound to be set

Shouldn't sqrt(2) be typeset in math mode?

(Though I generally hate that: For every "p" in p-adic an image is generated by TeX for the HTML documentation, which takes by far more than half of the docbuild time.)

Surely Sphinx caches and reuses these bits and pieces of TeX-generated images. A small grep for some of the more often used images (like $A$) seemed to indicate that at least...

Might be true. Nevertheless, then even generating a single image file for every used math character (or short math-typeset identifier) takes a big amount of time, and btw. looks pretty ugly for e.g. p-adic in the HTML documentation. (The latter is what disturbs me more, but such mark-up is widely used in Sage, even for numbers in a word like 2-descent. If we one day build the documentation in parallel, too, the former is less of an issue, though it also takes more disk space. The ratio build:doc:ptestlong is about 3:2:3 on my newer machines; on older machines ptestlong takes longer.)

comment:12 Changed 12 years ago by jdemeyer

  • Merged in set to sage-4.6.1.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.