Opened 9 years ago

Closed 9 years ago

#10189 closed enhancement (fixed)

Additions to the ones matrix constructor

Reported by: rbeezer Owned by: jason, was
Priority: minor Milestone: sage-4.6.2
Component: linear algebra Keywords:
Cc: jason, rlm, flawrence Merged in: sage-4.6.2.alpha0
Authors: Rob Beezer Reviewers: Karl-Dieter Crisman, Robert Miller
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by rbeezer)

This ticket began with building an all-ones matrix constructor, as contained on the first patch. But that was already happening over on #9685.

New title, new decription, new patch are about adding onto the ones_matrix constructor. Specifically,

  1. Significant additions to the documentation.
  1. Setting nrows=None in the function definition allows for a call with just a single integer entry, producing a square matrix over the integers, similar to the behavior for identity_matrix. Requires one new error-check.
  1. Isn't it better to coerce a generic 1 into the ring and then use that to populate the matrix? I've done that.

Attachments (1)

trac_10189-all-ones-additions-v1.patch (3.9 KB) - added by rbeezer 9 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by rbeezer

  • Status changed from new to needs_review

comment:2 follow-up: Changed 9 years ago by kcrisman

  • Authors set to Rob Beezer
  • Reviewers set to Karl-Dieter Crisman
  • Status changed from needs_review to needs_work

Like the concept, don't like the INPUT block. Can you make it look more like the other ones, say in plotting - with bullet points and entry type and defaults, that is? At least, I think the current one won't look that nice.

comment:3 in reply to: ↑ 2 ; follow-up: Changed 9 years ago by rbeezer

  • Cc rlm flawrence added

Replying to kcrisman:

Like the concept, don't like the INPUT block. Can you make it look more like the other ones, say in plotting - with bullet points and entry type and defaults, that is? At least, I think the current one won't look that nice.

Thanks, KDC. Was just too sloppy and forgot the bullets.

Tried to work on this and discovered a ones_matrix constructor was merged into 4.6.1.alpha1 at #9685! Guess I was not paying attention as well, since it was over in "user interface." Looks like Robert Miller did like I did and cribbed from the zero_matrix constructor, so I think there is not much difference between his and mine.

I do have an INPUT block in my documentation, even if it needs work. ;-) Should I steal from my work here and slightly improve the already-merged version? I've cc'ed the folks on the previous ticket.

Rob

comment:4 in reply to: ↑ 3 Changed 9 years ago by rlm

Replying to rbeezer:

I do have an INPUT block in my documentation, even if it needs work. ;-) Should I steal from my work here and slightly improve the already-merged version? I've cc'ed the folks on the previous ticket.

Might as well do the same thing for the zero_matrix et al. as well.

I see no reason why this ticket shouldn't be renamed to reflect this new purpose...

Changed 9 years ago by rbeezer

comment:5 Changed 9 years ago by rbeezer

  • Description modified (diff)
  • Status changed from needs_work to needs_review
  • Summary changed from Add the all-ones matrix constructor to Additions to the ones matrix constructor

comment:6 Changed 9 years ago by jason

Apply trac_10189-all-ones-additions-v1.patch

comment:7 Changed 9 years ago by rlm

  • Reviewers changed from Karl-Dieter Crisman to Karl-Dieter Crisman, Robert Miller
  • Status changed from needs_review to positive_review

comment:8 Changed 9 years ago by jdemeyer

  • Milestone changed from sage-4.6.1 to sage-4.6.2

comment:9 Changed 9 years ago by jdemeyer

  • Merged in set to sage-4.6.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.