#10162 closed defect (fixed)
sage-location: "update" library files the first time this is run
Reported by: | jhpalmieri | Owned by: | GeorgSWeber |
---|---|---|---|
Priority: | minor | Milestone: | sage-4.6.1 |
Component: | build | Keywords: | |
Cc: | leif | Merged in: | sage-4.6.1.alpha0 |
Authors: | John Palmieri | Reviewers: | Leif Leonhardy |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
If you build Sage but do not run it, then the script sage-location
does not get run, so the file $SAGE_ROOT/local/lib/sage-current-location.txt
does not get written. So if you move the Sage install directory before running it, the paths in the files SAGE_ROOT/local/lib/*.la
are not correct. The attached patch updates the paths in those files if the file sage-current-location.txt
does not exist.
(I'm marking this "minor" since it's not likely to happen at all frequently. When it does happen, it can screw things up pretty badly, though.)
Attachments (1)
Change History (7)
Changed 10 years ago by
comment:1 Changed 10 years ago by
- Status changed from new to needs_review
comment:2 Changed 10 years ago by
- Description modified (diff)
- Reviewers set to Leif Leonhardy
- Status changed from needs_review to positive_review
Except that the file's name is sage-current-location.txt
...
Good catch by the way, I assumed it was an even larger, perhaps OS-related problem.
comment:3 Changed 10 years ago by
Personal note (or to whom it may concern): ;-)
- Open a follow-up to also improve
sage-sage
:- Check exit code of
sage-location
before runningsage-upgrade
, too. - Call
sage-location
also before runningsage-spkg
. - Trap
SIGINT
while runningsage-location
(?) (such that we end up in a defined state in case it gets interrupted; perhaps requires further modification ofsage-location
as well)
- Check exit code of
- Open a follow-up to make
sage-location
a bit verbose? (aids debugging)
(I'm happy with this ticket as is, therefore further changes like the above should IMHO be made on follow-up tickets.)
comment:4 Changed 10 years ago by
- Merged in set to sage-4.6.1.alpha0
- Resolution set to fixed
- Status changed from positive_review to closed
comment:5 Changed 10 years ago by
- Milestone changed from sage-4.6 to sage-4.6.1
comment:6 Changed 10 years ago by
See #10202 for a follow-up (regarding when sage-location
is called [first], and especially patching / "initializing" pkg-config's .pc
files).
scripts repo